Skip to content

Commit 3a09ecb

Browse files
wenyiz2021wenyiz2021
authored
[masic] 'show interfaces counters' reminds to use '-d all' option to check for internal links (#2466)
Print reminder to check internal links on multi-asic platforms Signed-off-by: Wenyi Zhang <[email protected]>
1 parent 65cf00a commit 3a09ecb

File tree

3 files changed

+37
-3
lines changed

3 files changed

+37
-3
lines changed

‎scripts/portstat

+4-1
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,8 @@ class Portstat(object):
337337
print(table_as_json(table, header))
338338
else:
339339
print(tabulate(table, header, tablefmt='simple', stralign='right'))
340+
if multi_asic.is_multi_asic():
341+
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")
340342

341343
def cnstat_intf_diff_print(self, cnstat_new_dict, cnstat_old_dict, intf_list):
342344
"""
@@ -553,7 +555,8 @@ class Portstat(object):
553555
print(table_as_json(table, header))
554556
else:
555557
print(tabulate(table, header, tablefmt='simple', stralign='right'))
556-
558+
if multi_asic.is_multi_asic():
559+
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")
557560

558561
def main():
559562
parser = argparse.ArgumentParser(description='Display the ports state and counters',

‎tests/conftest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,9 @@ def setup_bgp_commands():
331331
@pytest.fixture
332332
def setup_ip_route_commands():
333333
import show.main as show
334-
335334
return show
336335

336+
337337
@pytest.fixture
338338
def setup_fib_commands():
339339
import show.main as show

‎tests/portstat_test.py

+32-1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@
7575
--------- ------- ------- -------- --------- -------- -------- -------- ------- -------- --------- -------- -------- --------
7676
Ethernet0 U 8 0.00 B/s 0.00% 10 100 N/A 10 0.00 B/s 0.00% N/A N/A N/A
7777
Ethernet4 U 4 0.00 B/s 0.00% 0 1,000 N/A 40 0.00 B/s 0.00% N/A N/A N/A
78+
79+
Reminder: Please execute 'show interface counters -d all' to include internal links
80+
7881
"""
7982

8083
multi_asic_all_intf_counters = """\
@@ -86,6 +89,9 @@
8689
Ethernet-BP4 U 8 0.00 B/s 0.00% 0 1,000 N/A 80 0.00 B/s 0.00% N/A N/A N/A
8790
Ethernet-BP256 U 8 0.00 B/s 0.00% 10 100 N/A 10 0.00 B/s 0.00% N/A N/A N/A
8891
Ethernet-BP260 U 4 0.00 B/s 0.00% 0 1,000 N/A 40 0.00 B/s 0.00% N/A N/A N/A
92+
93+
Reminder: Please execute 'show interface counters -d all' to include internal links
94+
8995
"""
9096
multi_asic_intf_counters_asic0 = """\
9197
IFACE STATE RX_OK RX_BPS RX_UTIL RX_ERR RX_DRP RX_OVR TX_OK TX_BPS TX_UTIL TX_ERR TX_DRP TX_OVR
@@ -94,13 +100,19 @@
94100
Ethernet4 U 4 0.00 B/s 0.00% 0 1,000 N/A 40 0.00 B/s 0.00% N/A N/A N/A
95101
Ethernet-BP0 U 6 0.00 B/s 0.00% 0 1,000 N/A 60 0.00 B/s 0.00% N/A N/A N/A
96102
Ethernet-BP4 U 8 0.00 B/s 0.00% 0 1,000 N/A 80 0.00 B/s 0.00% N/A N/A N/A
103+
104+
Reminder: Please execute 'show interface counters -d all' to include internal links
105+
97106
"""
98107

99108
multi_asic_external_intf_counters_printall = """\
100109
IFACE STATE RX_OK RX_BPS RX_PPS RX_UTIL RX_ERR RX_DRP RX_OVR TX_OK TX_BPS TX_PPS TX_UTIL TX_ERR TX_DRP TX_OVR
101110
--------- ------- ------- -------- -------- --------- -------- -------- -------- ------- -------- -------- --------- -------- -------- --------
102111
Ethernet0 U 8 0.00 B/s 0.00/s 0.00% 10 100 N/A 10 0.00 B/s 0.00/s 0.00% N/A N/A N/A
103112
Ethernet4 U 4 0.00 B/s 0.00/s 0.00% 0 1,000 N/A 40 0.00 B/s 0.00/s 0.00% N/A N/A N/A
113+
114+
Reminder: Please execute 'show interface counters -d all' to include internal links
115+
104116
"""
105117

106118
multi_asic_intf_counters_printall = """\
@@ -112,6 +124,9 @@
112124
Ethernet-BP4 U 8 0.00 B/s 0.00/s 0.00% 0 1,000 N/A 80 0.00 B/s 0.00/s 0.00% N/A N/A N/A
113125
Ethernet-BP256 U 8 0.00 B/s 0.00/s 0.00% 10 100 N/A 10 0.00 B/s 0.00/s 0.00% N/A N/A N/A
114126
Ethernet-BP260 U 4 0.00 B/s 0.00/s 0.00% 0 1,000 N/A 40 0.00 B/s 0.00/s 0.00% N/A N/A N/A
127+
128+
Reminder: Please execute 'show interface counters -d all' to include internal links
129+
115130
"""
116131

117132
multi_asic_intf_counters_asic0_printall = """\
@@ -121,13 +136,19 @@
121136
Ethernet4 U 4 0.00 B/s 0.00/s 0.00% 0 1,000 N/A 40 0.00 B/s 0.00/s 0.00% N/A N/A N/A
122137
Ethernet-BP0 U 6 0.00 B/s 0.00/s 0.00% 0 1,000 N/A 60 0.00 B/s 0.00/s 0.00% N/A N/A N/A
123138
Ethernet-BP4 U 8 0.00 B/s 0.00/s 0.00% 0 1,000 N/A 80 0.00 B/s 0.00/s 0.00% N/A N/A N/A
139+
140+
Reminder: Please execute 'show interface counters -d all' to include internal links
141+
124142
"""
125143
multi_asic_intf_counters_period = """\
126144
The rates are calculated within 3 seconds period
127145
IFACE STATE RX_OK RX_BPS RX_UTIL RX_ERR RX_DRP RX_OVR TX_OK TX_BPS TX_UTIL TX_ERR TX_DRP TX_OVR
128146
--------- ------- ------- -------- --------- -------- -------- -------- ------- -------- --------- -------- -------- --------
129147
Ethernet0 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
130148
Ethernet4 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
149+
150+
Reminder: Please execute 'show interface counters -d all' to include internal links
151+
131152
"""
132153

133154
multi_asic_intf_counters_period_all = """\
@@ -140,6 +161,9 @@
140161
Ethernet-BP4 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
141162
Ethernet-BP256 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
142163
Ethernet-BP260 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
164+
165+
Reminder: Please execute 'show interface counters -d all' to include internal links
166+
143167
"""
144168

145169
multi_asic_intf_counter_period_asic_all = """\
@@ -150,6 +174,9 @@
150174
Ethernet4 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
151175
Ethernet-BP0 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
152176
Ethernet-BP4 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
177+
178+
Reminder: Please execute 'show interface counters -d all' to include internal links
179+
153180
"""
154181

155182
mutli_asic_intf_counters_after_clear = """\
@@ -160,7 +187,11 @@
160187
Ethernet-BP0 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
161188
Ethernet-BP4 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
162189
Ethernet-BP256 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
163-
Ethernet-BP260 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A"""
190+
Ethernet-BP260 U 0 0.00 B/s 0.00% 0 0 N/A 0 0.00 B/s 0.00% N/A N/A N/A
191+
192+
Reminder: Please execute 'show interface counters -d all' to include internal links
193+
"""
194+
164195

165196
intf_invalid_asic_error = """ValueError: Unknown Namespace asic99"""
166197

0 commit comments

Comments
 (0)