Skip to content

Commit 3445104

Browse files
authored
[202012] Fix vs check install login timeout issue (#11727) (#12011)
Why I did it Fix a build not stable issue: #11620 The vs vm has started successfully, but failed to wait for the message "sonic login:". There were 55 builds failed caused by the issue in the last 30 days. AzurePipelineBuildLogs | where startTime > ago(30d) | where type =~ "task" | where result =~ "failed" | where name =~ "Build sonic image" | where content contains "Timeout exceeded" | where content contains "re.compile('sonic login:')" | project-away content | extend branchName=case(reason=~"pullRequest", tostring(todynamic(parameters)['system.pullRequest.targetBranch']), replace("refs/heads/", "", sourceBranch)) | summarize FailedCount=dcount(buildId) by branchName branchName FailedCount master 37 202012 9 202106 4 202111 2 202205 1 201911 1 It is caused by the login message mixed with the output message of the /etc/rc.local, one of the examples as below: (see the message rc.local[307]: sonic+ onie_disco_subnet=255.255.255.0 login: ) The check_install.py was waiting for the message "sonic login:", and Linux console was waiting for the username input (the login message has already printed in the console). https://dev.azure.com/mssonic/build/_build/results?buildId=123294&view=logs&j=cef3d8a9-152e-5193-620b-567dc18af272&t=359769c4-8b5e-5976-a793-85da132e0a6f 2022-07-17T15:00:58.9198877Z [ 25.493855] rc.local[307]: + onie_disco_opt53=05 2022-07-17T15:00:58.9199330Z [ 25.595054] rc.local[307]: + onie_disco_router=10.0.2.2 2022-07-17T15:00:58.9199781Z [ 25.699409] rc.local[307]: + onie_disco_serverid=10.0.2.2 2022-07-17T15:00:58.9200252Z [ 25.789891] rc.local[307]: + onie_disco_siaddr=10.0.2.2 2022-07-17T15:00:58.9200622Z [ 25.880920] 2022-07-17T15:00:58.9200745Z 2022-07-17T15:00:58.9201019Z Debian GNU/Linux 10 sonic ttyS0 2022-07-17T15:00:58.9201201Z 2022-07-17T15:00:58.9201542Z rc.local[307]: sonic+ onie_disco_subnet=255.255.255.0 login: 2022-07-17T15:00:58.9202309Z [ 26.079767] rc.local[307]: + onie_exec_url=file://dev/vdb/onie-installer.bin How I did it Input a newline when finished to run the script /etc/rc.local. If entering a newline, the message "sonic login:" will prompt again.
1 parent d892214 commit 3445104

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

check_install.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ def main():
2424
passwd_prompt = 'Password:'
2525
cmd_prompt = "{}@sonic:~\$ $".format(args.u)
2626
grub_selection = "The highlighted entry will be executed"
27+
firsttime_prompt = 'firsttime_exit'
2728

2829
i = 0
2930
while True:
@@ -43,14 +44,18 @@ def main():
4344

4445
# install sonic image
4546
while True:
46-
i = p.expect([login_prompt, passwd_prompt, grub_selection, cmd_prompt])
47+
i = p.expect([login_prompt, passwd_prompt, firsttime_prompt, grub_selection, cmd_prompt])
4748
if i == 0:
4849
# send user name
4950
p.sendline(args.u)
5051
elif i == 1:
5152
# send password
5253
p.sendline(args.P)
5354
elif i == 2:
55+
# fix a login timeout issue, caused by the login_prompt message mixed with the output message of the rc.local
56+
time.sleep(1)
57+
p.sendline()
58+
elif i == 3:
5459
# select onie install
5560
p.sendline()
5661
else:

0 commit comments

Comments
 (0)