Skip to content

Commit 17d44c2

Browse files
committed
Made Changes to be Python 3.7 compatible
Signed-off-by: Abhishek Dosi <[email protected]>
1 parent 978afb5 commit 17d44c2

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

scripts/hostcfgd

+10-2
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,11 @@ class FeatureHandler(object):
208208
self._feature_state_table._del(feature_name)
209209
return
210210

211-
feature = Feature(feature_name, feature_cfg, self._device_config | self._device_running_config)
211+
device_config = {}
212+
device_config.update(self._device_config)
213+
device_config.update(self._device_running_config)
214+
215+
feature = Feature(feature_name, feature_cfg, device_config)
212216
self._cached_config.setdefault(feature_name, Feature(feature_name, {}))
213217

214218
# Change auto-restart configuration first.
@@ -239,8 +243,12 @@ class FeatureHandler(object):
239243
if not feature_name:
240244
syslog.syslog(syslog.LOG_WARNING, "Feature is None")
241245
continue
246+
247+
device_config = {}
248+
device_config.update(self._device_config)
249+
device_config.update(self._device_running_config)
242250

243-
feature = Feature(feature_name, feature_table[feature_name], self._device_config | self._device_running_config)
251+
feature = Feature(feature_name, feature_table[feature_name], device_config)
244252

245253
self._cached_config.setdefault(feature_name, feature)
246254
self.update_systemd_config(feature)

tests/hostcfgd/hostcfgd_test.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -134,14 +134,16 @@ def test_sync_state_field(self, test_scenario_name, config_data, fs):
134134

135135
device_config = {}
136136
device_config['DEVICE_METADATA'] = MockConfigDb.CONFIG_DB['DEVICE_METADATA']
137+
device_config.update(config_data['device_runtime_metadata'])
138+
137139
feature_handler = hostcfgd.FeatureHandler(MockConfigDb(), feature_state_table_mock, device_config)
138140

139141
feature_table = MockConfigDb.CONFIG_DB['FEATURE']
140142
feature_handler.sync_state_field(feature_table)
141143

142144
feature_systemd_name_map = {}
143145
for feature_name in feature_table.keys():
144-
feature = hostcfgd.Feature(feature_name, feature_table[feature_name], device_config | config_data['device_runtime_metadata'])
146+
feature = hostcfgd.Feature(feature_name, feature_table[feature_name], device_config)
145147
feature_names, _ = feature_handler.get_multiasic_feature_instances(feature)
146148
feature_systemd_name_map[feature_name] = feature_names
147149

@@ -188,14 +190,15 @@ def test_handler(self, test_scenario_name, config_data, fs):
188190

189191
device_config = {}
190192
device_config['DEVICE_METADATA'] = MockConfigDb.CONFIG_DB['DEVICE_METADATA']
193+
device_config.update(config_data['device_runtime_metadata'])
191194
feature_handler = hostcfgd.FeatureHandler(MockConfigDb(), feature_state_table_mock, device_config)
192195

193196
feature_table = MockConfigDb.CONFIG_DB['FEATURE']
194197

195198
feature_systemd_name_map = {}
196199
for feature_name, feature_config in feature_table.items():
197200
feature_handler.handler(feature_name, 'SET', feature_config)
198-
feature = hostcfgd.Feature(feature_name, feature_table[feature_name], device_config | config_data['device_runtime_metadata'])
201+
feature = hostcfgd.Feature(feature_name, feature_table[feature_name], device_config)
199202
feature_names, _ = feature_handler.get_multiasic_feature_instances(feature)
200203
feature_systemd_name_map[feature_name] = feature_names
201204

0 commit comments

Comments
 (0)