Skip to content

Commit 0427468

Browse files
fix LGTM warningns
Signed-off-by: Stepan Blyshchak <[email protected]>
1 parent 759fbd9 commit 0427468

File tree

2 files changed

+36
-11
lines changed

2 files changed

+36
-11
lines changed

src/sonic-package-manager/sonic_package_manager/manager.py

+30-5
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,53 @@
11
#!/usr/bin/env python
22
import contextlib
33
import functools
4+
import os
45
import pkgutil
56
import tempfile
6-
from typing import Any, Iterable
7+
from typing import Any, Iterable, Callable, Dict, Optional
78

89
import docker
910
import filelock
1011
from sonic_py_common import device_info
1112

1213
from sonic_package_manager import utils
13-
from sonic_package_manager.database import *
14-
from sonic_package_manager.errors import *
14+
from sonic_package_manager.constraint import PackageConstraint
15+
from sonic_package_manager.database import (
16+
PACKAGE_MANAGER_LOCK_FILE,
17+
PackageDatabase
18+
)
19+
from sonic_package_manager.dockerapi import DockerApi
20+
from sonic_package_manager.errors import (
21+
PackageManagerError,
22+
PackageDependencyError,
23+
PackageConflictError,
24+
PackageInstallationError,
25+
PackageSonicRequirementError,
26+
PackageUninstallationError,
27+
PackageUpgradeError
28+
)
1529
from sonic_package_manager.logger import log
30+
from sonic_package_manager.manifest_resolver import ManifestResolver
31+
from sonic_package_manager.package import Package
1632
from sonic_package_manager.progress import ProgressManager
1733
from sonic_package_manager.reference import PackageReference
1834
from sonic_package_manager.registry import RegistryResolver
1935
from sonic_package_manager.service_creator.creator import ServiceCreator, run_command
2036
from sonic_package_manager.service_creator.feature import FeatureRegistry
2137
from sonic_package_manager.service_creator.sonic_db import SonicDB
2238
from sonic_package_manager.service_creator.utils import in_chroot
23-
from sonic_package_manager.source import *
39+
from sonic_package_manager.source import (
40+
PackageSource,
41+
LocalSource,
42+
RegistrySource,
43+
TarballSource
44+
)
2445
from sonic_package_manager.utils import DockerReference
25-
from sonic_package_manager.version import *
46+
from sonic_package_manager.version import (
47+
Version,
48+
VersionRange,
49+
version_to_tag, tag_to_version
50+
)
2651

2752

2853
@contextlib.contextmanager

src/sonic-package-manager/sonic_package_manager/source.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ def __init__(self,
8585
database: PackageDatabase,
8686
docker: DockerApi,
8787
manifest_resolver: ManifestResolver):
88-
super(TarballSource, self).__init__(database,
89-
docker,
90-
manifest_resolver)
88+
super().__init__(database,
89+
docker,
90+
manifest_resolver)
9191
self.tarball_path = tarball_path
9292

9393
def get_manifest(self) -> Manifest:
@@ -110,9 +110,9 @@ def __init__(self,
110110
database: PackageDatabase,
111111
docker: DockerApi,
112112
manifest_resolver: ManifestResolver):
113-
super(RegistrySource, self).__init__(database,
114-
docker,
115-
manifest_resolver)
113+
super().__init__(database,
114+
docker,
115+
manifest_resolver)
116116
self.repository = repository
117117
self.reference = reference
118118

0 commit comments

Comments
 (0)