[🔥AUDIT🔥] Move to pnpm (#1795)

🖍 _This is an audit!_ 🖍

## Summary:
This moves off `yarn` and onto `pnpm`. It also updates package deps to latest versions. This is a minimal impact on end users since these are all dev dependencies.

Issue: Closes #1758

## Test plan:
`pnpm clean & pnpm build`
`pnpm eslint`

Author: somewhatabstract

Auditors: copilot-pull-request-reviewer[bot]

Required Reviewers:

Approved By:

Checks: ✅ 8 checks were successful, ⏭️  1 check has been skipped

Pull Request URL: #1795

Author: somewhatabstract

.changeset/quick-turkeys-hang.md

@@ -0,0 +1,5 @@
+---
+"ancesdir": patch
+---
+
+Move to pnpm and update dev dependencies to latest

.github/dependabot.yml

@@ -3,9 +3,21 @@ updates:
 - package-ecosystem: npm
   directory: "/"
   schedule:
-    interval: daily
+    interval: weekly
+    day: saturday
     time: "09:00"
     timezone: America/Chicago
   open-pull-requests-limit: 10
   reviewers:
   - somewhatabstract
+
+- package-ecosystem: github-actions
+  directory: "/"
+  schedule:
+    interval: weekly
+    day: saturday
+    time: "09:00"
+    timezone: America/Chicago
+  open-pull-requests-limit: 10
+  reviewers:
+  - somewhatabstract

.github/workflows/codeql-analysis.yml

@@ -39,11 +39,11 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
+      uses: github/codeql-action/init@v3
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
@@ -54,7 +54,7 @@ jobs:
     # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
-      uses: github/codeql-action/autobuild@v2
+      uses: github/codeql-action/autobuild@v3
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 https://git.io/JvXDl
@@ -68,4 +68,4 @@ jobs:
     #   make release
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v2
+      uses: github/codeql-action/analyze@v3

.github/workflows/nodejs.yml

@@ -21,14 +21,30 @@ jobs:
         node-version: [20.x]
     steps:
     - uses: actions/checkout@v4
-    - name: Install & cache node_modules
-      uses: Khan/actions@shared-node-cache-v2
+
+    - uses: pnpm/action-setup@v4
+      name: Install pnpm
+      with:
+        run_install: false
+        package_json_file: 'package.json'
+
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
+        cache: 'pnpm'
+        cache-dependency-path: 'pnpm-lock.yaml'
+
+    - name: Install Dependencies
+      shell: bash
+      run: pnpm install --frozen-lockfile
+
     - name: Lint
-      run: yarn lint
+      run: pnpm eslint
+
     - name: Types
-      run: yarn typecheck
+      run: pnpm typecheck
+
     - name: Changesets check
       uses: Khan/actions@check-for-changeset-v1
       if: |
@@ -49,12 +65,26 @@ jobs:
         node-version: [20.x]
     steps:
     - uses: actions/checkout@v4
-    - name: Install & cache node_modules
-      uses: Khan/actions@shared-node-cache-v2
+
+    - uses: pnpm/action-setup@v4
+      name: Install pnpm
+      with:
+        run_install: false
+        package_json_file: 'package.json'
+
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
+        cache: 'pnpm'
+        cache-dependency-path: 'pnpm-lock.yaml'
+
+    - name: Install Dependencies
+      shell: bash
+      run: pnpm install --frozen-lockfile
+
     - name: Run tests with coverage
-      run: yarn coverage
+      run: pnpm coverage
     - name: Upload coverage
       uses: codecov/codecov-action@v4
       env:
@@ -73,9 +103,23 @@ jobs:
         node-version: [20.x]
     steps:
     - uses: actions/checkout@v4
-    - name: Install & cache node_modules
-      uses: Khan/actions@shared-node-cache-v2
+
+    - uses: pnpm/action-setup@v4
+      name: Install pnpm
+      with:
+        run_install: false
+        package_json_file: 'package.json'
+
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
+        cache: 'pnpm'
+        cache-dependency-path: 'pnpm-lock.yaml'
+
+    - name: Install Dependencies
+      shell: bash
+      run: pnpm install --frozen-lockfile
+
     - name: Run tests and build
-      run: yarn build
+      run: pnpm build

.github/workflows/release.yml

@@ -36,16 +36,28 @@ jobs:
           fetch-depth: 0
           persist-credentials: false
 
-      - name: Install & cache node_modules
-        uses: Khan/actions@shared-node-cache-v2
+      - uses: pnpm/action-setup@v4
+        name: Install pnpm
+        with:
+          run_install: false
+          package_json_file: 'package.json'
+
+      - name: Use Node.js 20.x
+        uses: actions/setup-node@v4
         with:
           node-version: 20.x
+          cache: 'pnpm'
+          cache-dependency-path: 'pnpm-lock.yaml'
+
+      - name: Install Dependencies
+        shell: bash
+        run: pnpm install --frozen-lockfile
 
       - name: Create Release Pull Request or Publish to npm
         id: changesets
         uses: changesets/action@v1
         with:
-          publish: yarn publish:ci
+          publish: pnpm publish:ci
         env:
           # We use a Personal Access Token here rather than the GITHUB_TOKEN
           # so that it will trigger our other actions. The token has to be on

.npmrc

@@ -0,0 +1 @@
+engine-strict = true

CONTRIBUTING.md

@@ -22,8 +22,8 @@ To work in the `ancesdir` repository, follow these steps:
 
 1. Clone the repository
    `git clone [email protected]:somewhatabstract/ancesdir.git`
-2. Install `yarn` (see [🔗yarnpkg.com](https://yarnpkg.com))
-3. Run `yarn` to install the dependencies
+2. Install `pnpm` using `corepack install`
+3. Run `pnpm i` to install the dependencies
 
 You can now work on `ancesdir`. We prefer [🔗Visual Studio Code](https://code.visualstudio.com/) as our development environment (it's cross-platform and awesome), but please use what you feel comfortable with (we'll even forgive you for using vim).
 
@@ -43,17 +43,17 @@ We love code reviews. If there are open pull requests, please feel free to revie
 
 To ensure code quality, we use prettier, static typing, eslint, and jest. These are all executed when you submit a pull request to ensure the contribution meets our code quality standard.
 
-To execute these operations outside of a pull request or commit operation, you can use `yarn`.
+To execute these operations outside of a pull request or commit operation, you can use `pnpm`.
 
-- `yarn typecheck`
-- `yarn lint` or `yarn lint --fix` to autofix what can be
-- `yarn test`
+- `pnpm typecheck`
+- `pnpm eslint` or `pnpm eslint --fix` to autofix what can be
+- `pnpm test`
 
 💭**REMEMBER** If you would like to contribute code changes to the project, first make sure there's a corresponding issue for the change you wish to make.
 
 ## 📦 Build And Publish
 
-Anyone can create a local build of the distributed code by running `yarn build`.
+Anyone can create a local build of the distributed code by running `pnpm build`.
 
 Running the build will execute tests first.
 

README.md

@@ -10,6 +10,9 @@ This may be useful in a variety of situations. For example, a monorepo where you
 
 ## Getting Started
 
+### pnpm
+**`pnpm add ancesdir`**
+
 ### yarn
 
 **`yarn add ancesdir`**

eslint.config.mjs

@@ -21,9 +21,9 @@ export default [
     {
         ignores: [
             "**/node_modules",
-            "flow-typed/**/*.js",
             "**/coverage",
             "**/dist",
+            ".prettierrc.js",
         ],
     },
     ...compat.extends("@khanacademy"),
@@ -41,7 +41,9 @@ export default [
                 ...globals.node,
             },
         },
-
+    },
+    {
+        files: ["**/src/**", "**/__tests__/**/*.ts", "**/__mocks__/**/*.ts"],
         rules: {
             "constructor-super": "error",
             curly: "error",

package.json

@@ -14,8 +14,8 @@
     "private": false,
     "engines": {
         "node": ">=20",
-        "npm": "please-use-yarn",
-        "yarn": ">=1.18.0 <2"
+        "npm": "please-use-pnpm",
+        "yarn": "please-use-pnpm"
     },
     "keywords": [
         "find",
@@ -30,60 +30,59 @@
     "files": [
         "dist"
     ],
-    "dependencies": {},
     "devDependencies": {
-        "@babel/cli": "^7.24.7",
-        "@babel/core": "^7.24.7",
-        "@babel/eslint-parser": "^7.24.7",
-        "@babel/eslint-plugin": "^7.24.7",
-        "@babel/preset-env": "^7.24.7",
-        "@babel/preset-typescript": "^7.24.7",
-        "@changesets/cli": "^2.27.5",
-        "@eslint/compat": "^1.1.0",
-        "@eslint/eslintrc": "^3.1.0",
-        "@eslint/js": "^9.5.0",
-        "@khanacademy/eslint-config": "^4.0.0",
-        "@khanacademy/eslint-plugin": "^3.0.0",
+        "@babel/cli": "^7.27.0",
+        "@babel/core": "^7.26.10",
+        "@babel/eslint-parser": "^7.27.0",
+        "@babel/eslint-plugin": "^7.27.0",
+        "@babel/preset-env": "^7.26.9",
+        "@babel/preset-typescript": "^7.27.0",
+        "@changesets/cli": "^2.28.1",
+        "@eslint/compat": "^1.2.8",
+        "@eslint/eslintrc": "^3.3.1",
+        "@eslint/js": "^9.24.0",
+        "@khanacademy/eslint-config": "^5.2.1",
+        "@khanacademy/eslint-plugin": "^3.1.2",
         "@rollup/plugin-babel": "^6.0.4",
-        "@rollup/plugin-commonjs": "^26.0.1",
-        "@rollup/plugin-node-resolve": "^15.2.3",
-        "@types/jest": "^29.5.12",
+        "@rollup/plugin-commonjs": "^28.0.3",
+        "@rollup/plugin-node-resolve": "^16.0.1",
+        "@rollup/plugin-terser": "^0.4.4",
+        "@types/jest": "^29.5.14",
         "@types/node": "^20.14.2",
-        "@typescript-eslint/eslint-plugin": "^7.13.0",
-        "@typescript-eslint/parser": "^7.13.0",
+        "@typescript-eslint/eslint-plugin": "^8.29.0",
+        "@typescript-eslint/parser": "^8.29.0",
         "babel-jest": "^29.7.0",
-        "eslint": "^9.5.0",
-        "eslint-config-prettier": "^9.1.0",
-        "eslint-import-resolver-typescript": "^3.6.1",
+        "eslint": "^9.24.0",
+        "eslint-config-prettier": "^10.1.1",
+        "eslint-import-resolver-typescript": "^4.3.1",
         "eslint-plugin-eslint-comments": "^3.2.0",
-        "eslint-plugin-import": "^2.29.1",
-        "eslint-plugin-jest": "^28.6.0",
-        "eslint-plugin-jsx-a11y": "^6.8.0",
-        "eslint-plugin-prettier": "^5.1.3",
-        "eslint-plugin-react": "^7.34.2",
-        "globals": "^15.4.0",
+        "eslint-plugin-import": "^2.31.0",
+        "eslint-plugin-jest": "^28.11.0",
+        "eslint-plugin-jsx-a11y": "^6.10.2",
+        "eslint-plugin-prettier": "^5.2.6",
+        "eslint-plugin-react": "^7.37.5",
+        "globals": "^16.0.0",
         "jest": "^29.7.0",
         "jest-extended": "^4.0.2",
-        "prettier": "^3.3.2",
-        "rollup": "^4.18.0",
+        "prettier": "^3.5.3",
+        "rollup": "^4.39.0",
         "rollup-plugin-filesize": "^10.0.0",
-        "rollup-plugin-terser": "^7.0.2",
-        "typescript": "^5.4.5"
+        "typescript": "^5.8.3"
     },
     "resolutions": {
-        "nanomatch/kind-of": "^6.0.3",
-        "micromatch/kind-of": "^6.0.3",
-        "is-descriptor/kind-of": "^6.0.3"
+        "nanomatch>kind-of": "^6.0.3",
+        "micromatch>kind-of": "^6.0.3",
+        "is-descriptor>kind-of": "^6.0.3"
     },
     "scripts": {
-        "prepublishOnly": "yarn clean && yarn build",
+        "prepublishOnly": "pnpm clean && pnpm build",
         "clean": "rm -rf dist",
-        "build": "yarn test && rollup -c && yarn build:types",
+        "build": "pnpm test && rollup -c && pnpm build:types",
         "build:types": "tsc --emitDeclarationOnly --declaration --project tsconfig-types.json",
         "test": "jest --colors --config jest.config.js",
         "coverage": "jest --colors --config jest.config.js --coverage",
         "typecheck": "tsc --noEmit --project tsconfig.json",
-        "lint": "eslint --report-unused-disable-directives --config eslint.config.mjs \"{src,bin,__{tests,mocks}__}/**/*.ts\"",
-        "publish:ci": "git diff --stat --exit-code HEAD && yarn build && changeset publish"
-    }
-}
+        "publish:ci": "git diff --stat --exit-code HEAD && pnpm build && changeset publish"
+    },
+    "packageManager": "[email protected]+sha512.2d92c86b7928dc8284f53494fb4201f983da65f0fb4f0d40baafa5cf628fa31dae3e5968f12466f17df7e97310e30f343a648baea1b9b350685dafafffdf5808"
+}