Making Solidus leaner and more RESTFUL

[RyanofWoods]

There are some controllers/routes that are not RESTful. While maybe not all of them can/should be changed, I thought it could be good if we discuss and list which controller methods can be pushed to a new controller and if they would benefit by getting a RESTful name/route.

These changes could encourage cleaner code which will be benificial to the developers as well as the long-term maintainability of Solidus.

Here are the controllers that have none RESTful methods.

• API
  • Checkouts
  • Config [:money]
  • Orders [:cancel, :empty, :current, :mine]
  • Shipments
  • StoreCreditEvents
  • Taxons [:products]
• Backend
  • Cancellations [:short_ship]
  • Locale [:set]
  • OptionTypes [:update_values_positions]
  • Orders
  • Payments [:fire]
  • Products [:clone]
  • PromotionCodeBatches [:download]
  • Reimbursements [:perform]
  • Resource [:update_positions]
  • ReturnAuthorizations [:fire]
  • SearchController
  • StoreCredits
  • Users
  • VariantsIncludingMasterController
• Frontend
  • Content: [:cvv]
  • Checkout
  • Locale [:set]
  • Order [:populate, :empty]
  • Store

Italic indicates that the controller most likely cannot become fully RESTful

Note:
Not all controllers may benefit from becoming RESTful, for example, the LocaleController only has one method: set, making this method create would be confusing. CheckoutControllers is also arguably too distinct to fit the RESTful principle.

Planned Changes

• Frontend
  • [WIP] OrdersController#populate -> OrderContentsController#create (Move OrdersController#populate to new controller #4102)
  • OrdersController#empty - OrderContentsController#destroy