Skip to content

Commit b0bf8f4

Browse files
authored
Merge pull request #6017 from tvdeyen/give-more-dialogs-more-time-to-open0in-specs
tests: Give even more dialogs more time to open in tests
2 parents 381bc87 + 8d6f016 commit b0bf8f4

7 files changed

+13
-13
lines changed

admin/spec/features/adjustment_reasons_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
it "closing the modal keeps query params" do
3535
within("dialog") { click_on "Cancel" }
36-
expect(page).not_to have_selector("dialog")
36+
expect(page).not_to have_selector("dialog", wait: 5)
3737
expect(page.current_url).to include(query)
3838
end
3939

@@ -76,7 +76,7 @@
7676

7777
it "closing the modal keeps query params" do
7878
within("dialog") { click_on "Cancel" }
79-
expect(page).not_to have_selector("dialog")
79+
expect(page).not_to have_selector("dialog", wait: 5)
8080
expect(page.current_url).to include(query)
8181
end
8282

admin/spec/features/refund_reasons_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
it "closing the modal keeps query params" do
3535
within("dialog") { click_on "Cancel" }
36-
expect(page).not_to have_selector("dialog")
36+
expect(page).not_to have_selector("dialog", wait: 5)
3737
expect(page.current_url).to include(query)
3838
end
3939

@@ -73,7 +73,7 @@
7373

7474
it "closing the modal keeps query params" do
7575
within("dialog") { click_on "Cancel" }
76-
expect(page).not_to have_selector("dialog")
76+
expect(page).not_to have_selector("dialog", wait: 5)
7777
expect(page.current_url).to include(query)
7878
end
7979

admin/spec/features/return_reasons_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
it "closing the modal keeps query params" do
3535
within("dialog") { click_on "Cancel" }
36-
expect(page).not_to have_selector("dialog")
36+
expect(page).not_to have_selector("dialog", wait: 5)
3737
expect(page.current_url).to include(query)
3838
end
3939

@@ -75,7 +75,7 @@
7575

7676
it "closing the modal keeps query params" do
7777
within("dialog") { click_on "Cancel" }
78-
expect(page).not_to have_selector("dialog")
78+
expect(page).not_to have_selector("dialog", wait: 5)
7979
expect(page.current_url).to include(query)
8080
end
8181

admin/spec/features/roles_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161

6262
it "closing the modal keeps query params" do
6363
within("dialog") { click_on "Cancel" }
64-
expect(page).not_to have_selector("dialog")
64+
expect(page).not_to have_selector("dialog", wait: 5)
6565
expect(page.current_url).to include(query)
6666
end
6767

@@ -130,7 +130,7 @@
130130

131131
it "closing the modal keeps query params" do
132132
within("dialog") { click_on "Cancel" }
133-
expect(page).not_to have_selector("dialog")
133+
expect(page).not_to have_selector("dialog", wait: 5)
134134
expect(page.current_url).to include(query)
135135
end
136136

admin/spec/features/shipping_categories_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
it "closing the modal keeps query params" do
3535
within("dialog") { click_on "Cancel" }
36-
expect(page).not_to have_selector("dialog")
36+
expect(page).not_to have_selector("dialog", wait: 5)
3737
expect(page.current_url).to include(query)
3838
end
3939

@@ -73,7 +73,7 @@
7373

7474
it "closing the modal keeps query params" do
7575
within("dialog") { click_on "Cancel" }
76-
expect(page).not_to have_selector("dialog")
76+
expect(page).not_to have_selector("dialog", wait: 5)
7777
expect(page.current_url).to include(query)
7878
end
7979

admin/spec/features/store_credit_reasons_spec.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
it "closing the modal keeps query params" do
3535
within("dialog") { click_on "Cancel" }
36-
expect(page).not_to have_selector("dialog")
36+
expect(page).not_to have_selector("dialog", wait: 5)
3737
expect(page.current_url).to include(query)
3838
end
3939

@@ -73,7 +73,7 @@
7373

7474
it "closing the modal keeps query params" do
7575
within("dialog") { click_on "Cancel" }
76-
expect(page).not_to have_selector("dialog")
76+
expect(page).not_to have_selector("dialog", wait: 5)
7777
expect(page.current_url).to include(query)
7878
end
7979

admin/spec/features/tax_categories_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
it "closing the modal keeps query params" do
3737
within("dialog") { click_on "Cancel" }
38-
expect(page).not_to have_selector("dialog")
38+
expect(page).not_to have_selector("dialog", wait: 5)
3939
expect(page.current_url).to include(query)
4040
end
4141

0 commit comments

Comments
 (0)