Skip to content

Commit 5ce2941

Browse files
committed
CI: Skip install_solidus check on non-current version
The installer always uses the current released minor version (4.2 time writing this), but the check runs on all pipeline runs, wasting CI time and precious resources. Also it fails anyway, because of conflicting dependencies. So, we only run the check on main and latest minor now. (cherry picked from commit 8d653a5)
1 parent c8b5e4e commit 5ce2941

File tree

1 file changed

+27
-20
lines changed

1 file changed

+27
-20
lines changed

.circleci/config.yml

+27-20
Original file line numberDiff line numberDiff line change
@@ -236,26 +236,33 @@ jobs:
236236
ruby: "3.0"
237237
steps:
238238
- checkout
239-
- libvips
240-
241-
- install_solidus: { flags: "--sample=false --frontend=starter --authentication=devise" }
242-
- test_page: { expected_text: "The only eCommerce platform you’ll ever need." }
243-
- run:
244-
name: Ensure the correct PayPal is installed for SSF
245-
command: |
246-
cd /tmp/my_app
247-
bundle list | grep 'solidus_paypal_commerce_platform (1.'
248-
249-
- install_solidus: { flags: "--sample=false --frontend=starter --authentication=devise --payment-method=stripe" }
250-
- test_page: { expected_text: "The only eCommerce platform you’ll ever need." }
251-
252-
- install_dummy_app
253-
254-
- install_dummy_app: { extra_gems: "solidus_frontend" }
255-
- run:
256-
name: "Ensure solidus_frontend installer is run"
257-
command: |
258-
test -f /tmp/dummy_extension/spec/dummy/config/initializers/solidus_frontend.rb
239+
- when:
240+
condition:
241+
or:
242+
- equal: [main, << pipeline.git.branch >>]
243+
- equal: [v4.2, << pipeline.git.branch >>]
244+
steps:
245+
- libvips
246+
- install_solidus:
247+
flags: "--sample=false --frontend=starter --authentication=devise"
248+
- test_page:
249+
expected_text: "The only eCommerce platform you’ll ever need."
250+
- run:
251+
name: Ensure the correct PayPal is installed for SSF
252+
command: |
253+
cd /tmp/my_app
254+
bundle list | grep 'solidus_paypal_commerce_platform (1.'
255+
- install_solidus:
256+
flags: "--sample=false --frontend=starter --authentication=devise --payment-method=stripe"
257+
- test_page:
258+
expected_text: "The only eCommerce platform you’ll ever need."
259+
- install_dummy_app
260+
- install_dummy_app:
261+
extra_gems: "solidus_frontend"
262+
- run:
263+
name: "Ensure solidus_frontend installer is run"
264+
command: |
265+
test -f /tmp/dummy_extension/spec/dummy/config/initializers/solidus_frontend.rb
259266
260267
test_solidus:
261268
parameters:

0 commit comments

Comments
 (0)