Skip to content

Commit 4024df7

Browse files
kennyadslelia
andcommitted
Add a DummyApp sprockets 4 configuration manifest
This is needed from Sprockets, since v4. It contains all dependencies that needs to be compiled. Co-Authored-By: Elia Schito <[email protected]>
1 parent 6ef5c78 commit 4024df7

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

Gemfile

-5
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ else
1212
end
1313
# rubocop:enable Bundler/DuplicatedGem
1414

15-
# Temporarily locking sprockets to v3.x
16-
# see https://github.com/solidusio/solidus/issues/3374
17-
# and https://github.com/rails/sprockets-rails/issues/369
18-
gem 'sprockets', '~> 3'
19-
2015
gem 'pry'
2116
gem 'launchy', require: false
2217

core/lib/spree/testing_support/dummy_app.rb

+4-1
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,11 @@ module ApplicationHelper
3434
module DummyApp
3535
def self.setup(gem_root:, lib_name:, auto_migrate: true)
3636
ENV["LIB_NAME"] = lib_name
37-
DummyApp::Application.config.root = File.join(gem_root, 'spec', 'dummy')
37+
root = Pathname(gem_root).join('spec/dummy')
38+
root.join("app/assets/config").mkpath
39+
root.join("app/assets/config/manifest.js").write("// Intentionally empty\n")
3840

41+
DummyApp::Application.config.root = root
3942
DummyApp::Application.initialize! unless DummyApp::Application.initialized?
4043

4144
if auto_migrate
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
// This manifest is left empty because we are already
2+
// injecting Solidus manifests to be compiled in the
3+
// precompile array manually.

0 commit comments

Comments
 (0)