Skip to content

Commit 190bab4

Browse files
committed
Restrict sqlite3 for the extension generator
The task itself is fine, as it inherits from Rails' app generator, which has the sqlite3 restriction: https://github.com/rails/rails/blob/main/railties/lib/rails/generators/database.rb#L19.
1 parent 4319e17 commit 190bab4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.circleci/config.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,8 @@ commands:
224224
cd /tmp/dummy_extension
225225
bundle init
226226
bundle add rails -v "< 7.1" --skip-install
227-
bundle add sqlite3 <<parameters.extra_gems>> --skip-install
227+
bundle add sqlite3 -v "~> 1.3" --skip-install
228+
if [ -n "<<parameters.extra_gems>>"]; then bundle add <<parameters.extra_gems>> --skip-install; fi
228229
bundle add solidus --path "$(ruby -e"puts File.expand_path ENV['CIRCLE_WORKING_DIRECTORY']")"
229230
export LIB_NAME=set # dummy requireable file
230231
bundle exec rake -rrails -rspree/testing_support/extension_rake -e'Rake::Task["extension:test_app"].invoke'

0 commit comments

Comments
 (0)