feat: add load method (#2427)

WoLewicki · web-flow · commit 4a5674d3e004 · 2024-08-23T14:37:57.000+02:00
## PR concerning New Architecture support in the library 🎉 We at [Software Mansion](https://swmansion.com/) have been working on [improving support](https://blog.swmansion.com/sunrising-new-architecture-in-the-new-expensify-app-729d237a02f5) for the new architecture for quite a while now. If you need help with anything related to New Architecture, like: - [migrating your library](https://x.com/swmansion/status/1717512089323864275) - [migrating your app](Expensify/App#13767) - [investigating issues](https://github.com/facebook/react-native/pulls?q=sort%3Aupdated-desc+is%3Apr+author%3Aj-piasecki+is%3Aopen) - [improving performance](https://x.com/BBloniarz_/status/1808138585528303977) or you just want to ask any questions, hit us up on [projects@swmansion.com](mailto:projects@swmansion.com) --- ## Summary  PR adding `load` method needed for dynamic frameworks to work with the library. See facebook/react-native#37274 for more information.
diff --git a/apple/Elements/RNSVGClipPath.mm b/apple/Elements/RNSVGClipPath.mm
@@ -21,6 +21,12 @@ @implementation RNSVGClipPath
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGDefs.mm b/apple/Elements/RNSVGDefs.mm
@@ -20,6 +20,12 @@ @implementation RNSVGDefs
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGForeignObject.mm b/apple/Elements/RNSVGForeignObject.mm
@@ -23,6 +23,12 @@ @implementation RNSVGForeignObject
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGGroup.mm b/apple/Elements/RNSVGGroup.mm
@@ -25,6 +25,12 @@ @implementation RNSVGGroup {
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGImage.mm b/apple/Elements/RNSVGImage.mm
@@ -50,6 +50,12 @@ @implementation RNSVGImage {
 }
 #ifdef RCT_NEW_ARCH_ENABLED
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGLinearGradient.mm b/apple/Elements/RNSVGLinearGradient.mm
@@ -22,6 +22,12 @@ @implementation RNSVGLinearGradient
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGMarker.mm b/apple/Elements/RNSVGMarker.mm
@@ -24,6 +24,12 @@ @implementation RNSVGMarker
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGMask.mm b/apple/Elements/RNSVGMask.mm
@@ -23,6 +23,12 @@ @implementation RNSVGMask
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGPath.mm b/apple/Elements/RNSVGPath.mm
@@ -23,6 +23,12 @@ @implementation RNSVGPath {
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGPattern.mm b/apple/Elements/RNSVGPattern.mm
@@ -23,6 +23,12 @@ @implementation RNSVGPattern
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGRadialGradient.mm b/apple/Elements/RNSVGRadialGradient.mm
@@ -20,6 +20,12 @@ @implementation RNSVGRadialGradient
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGSvgView.mm b/apple/Elements/RNSVGSvgView.mm
@@ -34,6 +34,12 @@ @implementation RNSVGSvgView {
 using namespace facebook::react;
 #endif // RCT_NEW_ARCH_ENABLED
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGSymbol.mm b/apple/Elements/RNSVGSymbol.mm
@@ -21,6 +21,12 @@ @implementation RNSVGSymbol
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Elements/RNSVGUse.mm b/apple/Elements/RNSVGUse.mm
@@ -22,6 +22,12 @@ @implementation RNSVGUse
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Filters/RNSVGFeColorMatrix.mm b/apple/Filters/RNSVGFeColorMatrix.mm
@@ -14,6 +14,12 @@ @implementation RNSVGFeColorMatrix
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Filters/RNSVGFeGaussianBlur.mm b/apple/Filters/RNSVGFeGaussianBlur.mm
@@ -15,6 +15,12 @@ @implementation RNSVGFeGaussianBlur
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Filters/RNSVGFeMerge.mm b/apple/Filters/RNSVGFeMerge.mm
@@ -13,6 +13,12 @@ @implementation RNSVGFeMerge
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Filters/RNSVGFeOffset.mm b/apple/Filters/RNSVGFeOffset.mm
@@ -16,6 +16,12 @@ @implementation RNSVGFeOffset
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Filters/RNSVGFilter.mm b/apple/Filters/RNSVGFilter.mm
@@ -18,6 +18,12 @@ @implementation RNSVGFilter {
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Shapes/RNSVGCircle.mm b/apple/Shapes/RNSVGCircle.mm
@@ -22,6 +22,12 @@ @implementation RNSVGCircle
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Shapes/RNSVGEllipse.mm b/apple/Shapes/RNSVGEllipse.mm
@@ -22,6 +22,12 @@ @implementation RNSVGEllipse
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Shapes/RNSVGLine.mm b/apple/Shapes/RNSVGLine.mm
@@ -22,6 +22,12 @@ @implementation RNSVGLine
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Shapes/RNSVGRect.mm b/apple/Shapes/RNSVGRect.mm
@@ -22,6 +22,12 @@ @implementation RNSVGRect
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Text/RNSVGTSpan.mm b/apple/Text/RNSVGTSpan.mm
@@ -40,6 +40,12 @@ @implementation RNSVGTSpan {
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Text/RNSVGText.mm b/apple/Text/RNSVGText.mm
@@ -31,6 +31,12 @@ @implementation RNSVGText {
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {
diff --git a/apple/Text/RNSVGTextPath.mm b/apple/Text/RNSVGTextPath.mm
@@ -21,6 +21,12 @@ @implementation RNSVGTextPath
 #ifdef RCT_NEW_ARCH_ENABLED
 using namespace facebook::react;
 
+// Needed because of this: https://github.com/facebook/react-native/pull/37274
++ (void)load
+{
+  [super load];
+}
+
 - (instancetype)initWithFrame:(CGRect)frame
 {
   if (self = [super initWithFrame:frame]) {

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,12 @@ @implementation RNSVGImage {`
`50`	`50`	`}`
`51`	`51`	`#ifdef RCT_NEW_ARCH_ENABLED`
`52`	`52`
	`53`	`+// Needed because of this: https://github.com/facebook/react-native/pull/37274`
	`54`	`++ (void)load`
	`55`	`+{`
	`56`	`+ [super load];`
	`57`	`+}`
	`58`	`+`
`53`	`59`	`- (instancetype)initWithFrame:(CGRect)frame`
`54`	`60`	`{`
`55`	`61`	`if (self = [super initWithFrame:frame]) {`