Merge pull request Expensify#65425 from callstack-internal/Accounting-Loading-icon-and-sync-status-messages-are-not-displayed

Accounting-Loading icon and sync status messages are not displayed

Author: lakchote

src/libs/Pusher/index.native.ts

@@ -88,6 +88,39 @@ function getChannel(channelName: string): PusherChannel | undefined {
     return socket.getChannel(channelName);
 }
 
+/**
+ * Parses JSON data that may be single or double-encoded
+ * This handles cases where the backend sometimes sends double-encoded JSON
+ * Reference issue: https://github.com/Expensify/App/issues/60332
+ */
+function parseEventData<EventName extends PusherEventName>(eventData: EventData<EventName>): EventData<EventName> | null {
+    if (isObject(eventData)) {
+        return eventData;
+    }
+
+    if (typeof eventData !== 'string') {
+        Log.alert('[Pusher] Event data is neither object nor string', {eventData});
+        return null;
+    }
+
+    try {
+        const firstParse = JSON.parse(eventData) as EventData<EventName> | string;
+
+        // If result is still a string, it was double-encoded - parse again
+        if (typeof firstParse === 'string') {
+            return JSON.parse(firstParse) as EventData<EventName>;
+        }
+
+        return firstParse;
+    } catch (error) {
+        Log.alert('[Pusher] Failed to parse event data', {
+            error: error instanceof Error ? error.message : 'Unknown error',
+            eventData,
+        });
+        return null;
+    }
+}
+
 /**
  * Binds an event callback to a channel + eventName
  */
@@ -103,11 +136,9 @@ function bindEventToChannel<EventName extends PusherEventName>(channel: string,
             return;
         }
 
-        let data: EventData<EventName>;
-        try {
-            data = isObject(eventData) ? eventData : (JSON.parse(eventData) as EventData<EventName>);
-        } catch (err) {
-            Log.alert('[Pusher] Unable to parse single JSON event data from Pusher', {error: err, eventData});
+        const data = parseEventData(eventData);
+        if (!data) {
+            // Error already logged in parseEventData
             return;
         }
         if (data.id === undefined || data.chunk === undefined || data.final === undefined) {