Skip to content

Commit a098d4e

Browse files
committed
Fix node tests
finalhandler returns a request body that we do not expect. Use a simple 404 instead.
1 parent 030c66b commit a098d4e

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
"envify": "^4.0.0",
3838
"eslint": "^7.6.0",
3939
"expect.js": "~0.3.1",
40-
"finalhandler": "^1.1.2",
4140
"gulp": "^4.0.2",
4241
"gulp-header": "^2.0.9",
4342
"gulp-rename": "^2.0.0",

tests/support/sockjs_server.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
var http = require('http');
55
var serveStatic = require('serve-static');
6-
var finalhandler = require('finalhandler');
76
var sockjs = require('./sockjs_app');
87
var url = require('url');
98
var path = require('path');
@@ -19,7 +18,7 @@ function startServer(port, config, prefix) {
1918
}
2019
};
2120

22-
var serve = serveStatic(path.join(__dirname, '../html'));
21+
var serve = serveStatic(path.join(__dirname, '../html'), { fallthrough: false });
2322

2423
var server = http.createServer();
2524
server.addListener('request', function(req, res) {
@@ -53,7 +52,10 @@ function startServer(port, config, prefix) {
5352
res.end('var clientOptions = ' +
5453
JSON.stringify(clientOptions) + ';');
5554
} else {
56-
serve(req, res, finalhandler(req, res));
55+
serve(req, res, function(err) {
56+
var status = err ? err.statusCode : 404;
57+
return res.writeHead(status).end();
58+
});
5759
}
5860
});
5961
server.addListener('upgrade', function(req, res){

0 commit comments

Comments
 (0)