Skip to content

Commit 8d0ce5f

Browse files
Nick Tazelaardarrachequesne
Nick Tazelaar
authored andcommitted
[refactor] Add some checks to prevent usage of undefined properties (#540)
1 parent 1a685c0 commit 8d0ce5f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

lib/server.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -266,11 +266,13 @@ function sendErrorMessage (req, res, code) {
266266
} else {
267267
headers['Access-Control-Allow-Origin'] = '*';
268268
}
269-
res.writeHead(400, headers);
270-
res.end(JSON.stringify({
271-
code: code,
272-
message: Server.errorMessages[code]
273-
}));
269+
if (res !== undefined) {
270+
res.writeHead(400, headers);
271+
res.end(JSON.stringify({
272+
code: code,
273+
message: Server.errorMessages[code]
274+
}));
275+
}
274276
}
275277

276278
/**
@@ -379,7 +381,7 @@ Server.prototype.handleUpgrade = function (req, socket, upgradeHead) {
379381
Server.prototype.onWebSocket = function (req, socket) {
380382
socket.on('error', onUpgradeError);
381383

382-
if (!transports[req._query.transport].prototype.handlesUpgrades) {
384+
if (transports[req._query.transport] !== undefined && !transports[req._query.transport].prototype.handlesUpgrades) {
383385
debug('transport doesnt handle upgraded requests');
384386
socket.close();
385387
return;

0 commit comments

Comments
 (0)