Skip to content

SNOW-2111644 Support sovereign clouds for WIF #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

SNOW-2111644 Support sovereign clouds for WIF #2367

merged 2 commits into from
Jun 24, 2025

Conversation

sfc-gh-xizhao
Copy link
Contributor

@sfc-gh-xizhao sfc-gh-xizhao commented Jun 20, 2025 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-2111644

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds the support for sovereign clouds for WIF, specifically supporting additional partitions in AWS, and additional issuers in Azure.

  4. (Optional) PR for stored-proc connector:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-xizhao
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-pmansour
sfc-gh-pmansour approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-pmansour sfc-gh-pmansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

sfc-gh-jkasten
sfc-gh-jkasten approved these changes Jun 24, 2025
View reviewed changes
Copy link

@sfc-gh-jkasten sfc-gh-jkasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfc-gh-mmishchenko sfc-gh-mmishchenko force-pushed the xizhao-SNOW-2111644-wif-sovereign branch from 601e0ec to c2a6b12 Compare June 24, 2025 10:39
sfc-gh-mmishchenko
sfc-gh-mmishchenko approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-mmishchenko sfc-gh-mmishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-xizhao sfc-gh-xizhao force-pushed the xizhao-SNOW-2111644-wif-sovereign branch from c2a6b12 to f988426 Compare June 24, 2025 17:27
@sfc-gh-pmansour sfc-gh-pmansour added DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md labels Jun 24, 2025
@sfc-gh-xizhao sfc-gh-xizhao force-pushed the xizhao-SNOW-2111644-wif-sovereign branch from f988426 to 6db5576 Compare June 24, 2025 18:25
@sfc-gh-xizhao sfc-gh-xizhao merged commit 08dbaa8 into main Jun 24, 2025
92 of 97 checks passed
@sfc-gh-xizhao sfc-gh-xizhao deleted the xizhao-SNOW-2111644-wif-sovereign branch June 24, 2025 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmansour sfc-gh-pmansour sfc-gh-pmansour approved these changes

@sfc-gh-jkasten sfc-gh-jkasten sfc-gh-jkasten approved these changes

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

@sfc-gh-dbasavin sfc-gh-dbasavin Awaiting requested review from sfc-gh-dbasavin

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-xizhao @sfc-gh-pmansour @sfc-gh-jkasten @sfc-gh-mmishchenko