Skip to content

Adds audit notification for MS Teams #16414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

Godmartinz
Copy link
Member

This adds an audit notifications for MS Teams.
There was no notification being sent for MS Teams when an audit would be completed for an asset.
FD-46311
image

Verified

This commit was signed with the committer’s verified signature.
Chartman123 Christian Hartmann
@Godmartinz Godmartinz requested a review from snipe as a code owner March 4, 2025 19:18
@Godmartinz Godmartinz requested review from marcusmoore and snipe and removed request for snipe March 4, 2025 19:18
Copy link

what-the-diff bot commented Mar 4, 2025

PR Summary

  • Enhancement for Microsoft Teams Communication
    This update adds a function in the 'AuditNotification' class that supports formating messages specifically for Microsoft Teams. This means the system will now be able to send notifications via Microsoft Teams.

  • Logic for Conditional Notifications
    The update introduces conditional logic to determine if Microsoft Teams should be used for notifications. Depending on the user preference, if Microsoft Teams is selected as the webhook option, notifications will be sent through it. If not, the system will use Slack, as it has been.

  • Necessary Components Included
    Certain necessary components, termed 'namespaces', have been included in key classes. This ensures smooth communication and operation between different parts of the system, particularly when sending notifications.

  • Customizable Notification Channels
    The class that handles notifications now includes a mechanism to consider Microsoft Teams as a notification channel. The method checks the user's settings and includes Microsoft Teams as a possible channel for sending notifications accordingly. This provides users with more flexibility in choosing how they want to receive notifications.

@snipe snipe merged commit bc618fc into grokability:develop Mar 4, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants