tests: fix installing packages

make sure ansible exits correctly if installation fails

Author: sni

t/scenarios/_common/Makefile.common

@@ -14,6 +14,7 @@ else
   DOCKER_COMPOSE_LOGS=--no-color
 endif
 export COMPOSE_HTTP_TIMEOUT=180
+export COMPOSE_BAKE=true
 
 wait_start:
 	$(THRUK) cache clean

t/scenarios/_common/ansible/roles/yum_apt_retry/tasks/main.yml

@@ -12,12 +12,16 @@
           exit 0
         fi
       fi
+      RC=0
       if test -f /usr/bin/apt; then
         apt-get install -y {{ package | join(' ') }} {{ deb | join(' ') }}
+        RC=$?
       elif test -f /usr/bin/dnf; then
         dnf install -y {{ package | join(' ') }} {{ rpm | join(' ') }}
+        RC=$?
       else
         yum install -y {{ package | join(' ') }} {{ rpm | join(' ') }}
+        RC=$?
       fi
       for file in {{ creates | join(' ') }}; do
         if [ $(ls -l1 $(echo $file | tr , ' ') 2>/dev/null | wc -l) -eq 0 ]; then
@@ -27,13 +31,17 @@
           exit 1
         fi
       done
+      exit $RC
   register: install_result
   ignore_errors: yes
   failed_when: install_result.rc != 0
   retries: "{{ retries | default(5) }}"
   delay: "{{ delay | default(30) }}"
   until: install_result is succeeded
 
+- debug: var=install_result
+  when: install_result.rc != 0
+
 - name: Verify installation
   fail:
     msg: package installation failed