Skip to content

Commit 2d94094

Browse files
Bill Newmanjsnellbaker
Bill Newman
authored andcommitted
Colossus adapter changes for Prebid 3.0 (prebid#4476)
* add video&native traffic colossus ssp * Native obj validation * Native obj validation #2 * Added size field in requests * fixed test * fix merge conflicts * move to 3.0 * move to 3.0 * fix IE11 new URL issue * fix IE11 new URL issue * fix IE11 new URL issue * https for 3.0 * add https test
1 parent c4d9d07 commit 2d94094

File tree

3 files changed

+24
-13
lines changed

3 files changed

+24
-13
lines changed

modules/colossussspBidAdapter.js

+12-9
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes';
33
import * as utils from '../src/utils';
44

55
const BIDDER_CODE = 'colossusssp';
6-
const URL = '//colossusssp.com/?c=o&m=multi';
7-
const URL_SYNC = '//colossusssp.com/?c=o&m=cookie';
6+
const G_URL = 'https://colossusssp.com/?c=o&m=multi';
7+
const G_URL_SYNC = 'https://colossusssp.com/?c=o&m=cookie';
88

99
function isBidResponseValid(bid) {
1010
if (!bid.requestId || !bid.cpm || !bid.creativeId || !bid.ttl || !bid.currency) {
@@ -42,15 +42,16 @@ export const spec = {
4242
* @param {BidRequest[]} validBidRequests A non-empty list of valid bid requests that should be sent to the Server.
4343
* @return ServerRequest Info describing the request to the server.
4444
*/
45-
buildRequests: (validBidRequests) => {
45+
buildRequests: (validBidRequests, bidderRequest) => {
4646
let winTop = window;
47+
let location;
4748
try {
48-
window.top.location.toString();
49+
location = new URL(bidderRequest.refererInfo.referer)
4950
winTop = window.top;
5051
} catch (e) {
52+
location = winTop.location;
5153
utils.logMessage(e);
5254
};
53-
let location = utils.getTopWindowLocation();
5455
let placements = [];
5556
let request = {
5657
'deviceWidth': winTop.screen.width,
@@ -61,19 +62,21 @@ export const spec = {
6162
'page': location.pathname,
6263
'placements': placements
6364
};
65+
6466
for (let i = 0; i < validBidRequests.length; i++) {
6567
let bid = validBidRequests[i];
68+
let traff = bid.params.traffic || BANNER
6669
let placement = {
6770
placementId: bid.params.placement_id,
6871
bidId: bid.bidId,
69-
sizes: bid.sizes,
70-
traffic: bid.params.traffic || BANNER
72+
sizes: bid.mediaTypes[traff].sizes,
73+
traffic: traff
7174
};
7275
placements.push(placement);
7376
}
7477
return {
7578
method: 'POST',
76-
url: URL,
79+
url: G_URL,
7780
data: request
7881
};
7982
},
@@ -103,7 +106,7 @@ export const spec = {
103106
getUserSyncs: () => {
104107
return [{
105108
type: 'image',
106-
url: URL_SYNC
109+
url: G_URL_SYNC
107110
}];
108111
}
109112
};

modules/colossussspBidAdapter.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ Module that connects to Colossus SSP demand sources
1414
```
1515
var adUnits = [{
1616
code: 'placementid_0',
17-
sizes: [[300, 250]],
17+
mediaTypes: {
18+
banner: {
19+
sizes: [[300, 250], [300,600]]
20+
}
21+
},
1822
bids: [{
1923
bidder: 'colossusssp',
2024
params: {

test/spec/modules/colossussspBidAdapter_spec.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ describe('ColossussspAdapter', function () {
1111
},
1212
placementCode: 'placementid_0',
1313
auctionId: '74f78609-a92d-4cf1-869f-1b244bbfb5d2',
14-
sizes: [[300, 250]],
14+
mediaTypes: {
15+
banner: {
16+
sizes: [[300, 250]]
17+
}
18+
},
1519
transactionId: '3bb2f6da-87a6-4029-aeb0-bfe951372e62'
1620
};
1721

@@ -37,7 +41,7 @@ describe('ColossussspAdapter', function () {
3741
expect(serverRequest.method).to.equal('POST');
3842
});
3943
it('Returns valid URL', function () {
40-
expect(serverRequest.url).to.equal('//colossusssp.com/?c=o&m=multi');
44+
expect(serverRequest.url).to.equal('https://colossusssp.com/?c=o&m=multi');
4145
});
4246
it('Returns valid data if array of bids is valid', function () {
4347
let data = serverRequest.data;
@@ -112,7 +116,7 @@ describe('ColossussspAdapter', function () {
112116
expect(userSync[0].type).to.exist;
113117
expect(userSync[0].url).to.exist;
114118
expect(userSync[0].type).to.be.equal('image');
115-
expect(userSync[0].url).to.be.equal('//colossusssp.com/?c=o&m=cookie');
119+
expect(userSync[0].url).to.be.equal('https://colossusssp.com/?c=o&m=cookie');
116120
});
117121
});
118122
});

0 commit comments

Comments
 (0)