Skip to content

Commit d921430

Browse files
committed
more test fixes
1 parent fa1e86b commit d921430

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

server/src/test/java/org/elasticsearch/action/admin/cluster/stats/CCSTelemetrySnapshotTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ public void testToXContent() throws IOException {
325325
XContentHelper.toXContent(snapshot, XContentType.JSON, randomBoolean()),
326326
XContentType.JSON
327327
);
328+
assertToXContentEquivalent(new BytesArray(expectedJson), new BytesArray(snapshot.toString()), XContentType.JSON);
328329
}
329330

330331
private String readJSONFromResource(String fileName) throws IOException {

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterQueryIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ public void testSearchesAgainstNonMatchingIndices() throws Exception {
440440
List.of(
441441
new ExpectedCluster(
442442
LOCAL_CLUSTER,
443-
"alias-filtered-1*",
443+
localIndexName + "*",
444444
EsqlExecutionInfo.Cluster.Status.SUCCESSFUL,
445445
localNumShards
446446
),

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterUsageTelemetryIT.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,24 +118,23 @@ public void testFailed() throws Exception {
118118

119119
assertThat(telemetry.getTotalCount(), equalTo(1L));
120120
assertThat(telemetry.getSuccessCount(), equalTo(0L));
121-
assertThat(telemetry.getByRemoteCluster().size(), equalTo(0));
121+
assertThat(telemetry.getByRemoteCluster().size(), equalTo(1));
122122
assertThat(telemetry.getRemotesPerSearchAvg(), equalTo(2.0));
123123
assertThat(telemetry.getRemotesPerSearchMax(), equalTo(2L));
124-
assertThat(telemetry.getSearchCountWithSkippedRemotes(), equalTo(0L));
124+
assertThat(telemetry.getSearchCountWithSkippedRemotes(), equalTo(1L));
125125
Map<String, Long> expectedFailure = Map.of(CCSUsageTelemetry.Result.NOT_FOUND.getName(), 1L);
126126
assertThat(telemetry.getFailureReasons(), equalTo(expectedFailure));
127127

128-
// this is only for cluster-a so no skipped remotes
128+
// this is only for cluster-a now
129129
telemetry = getTelemetryFromFailedQuery("from logs-*,cluster-a:no_such_index | stats sum (v)");
130130
assertThat(telemetry.getTotalCount(), equalTo(2L));
131131
assertThat(telemetry.getSuccessCount(), equalTo(0L));
132-
assertThat(telemetry.getByRemoteCluster().size(), equalTo(0));
132+
assertThat(telemetry.getByRemoteCluster().size(), equalTo(1));
133133
assertThat(telemetry.getRemotesPerSearchAvg(), equalTo(2.0));
134134
assertThat(telemetry.getRemotesPerSearchMax(), equalTo(2L));
135-
assertThat(telemetry.getSearchCountWithSkippedRemotes(), equalTo(0L));
135+
assertThat(telemetry.getSearchCountWithSkippedRemotes(), equalTo(1L));
136136
expectedFailure = Map.of(CCSUsageTelemetry.Result.NOT_FOUND.getName(), 2L);
137137
assertThat(telemetry.getFailureReasons(), equalTo(expectedFailure));
138-
assertThat(telemetry.getByRemoteCluster().size(), equalTo(0));
139138
}
140139

141140
public void testRemoteOnly() throws Exception {

0 commit comments

Comments
 (0)