Skip to content

GCB: Does source pinning matter? #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asraa opened this issue Oct 17, 2022 · 1 comment
Open

GCB: Does source pinning matter? #309

asraa opened this issue Oct 17, 2022 · 1 comment
Labels
area:gcb Issue with the gcb verifier type:discussion A discussion or suggestion

Comments

@asraa
Copy link
Contributor

asraa commented Oct 17, 2022

As noted in #300

When GCB is used without a GitHub repository trigger, than it automatically pulls source into a GCS bucket for build: gs://PROJECT_cloudbuild/source

Currently, v1.4.1 of slsa-verifier still expects and requires a source match, and users would have to pass the source bucket in.

In #300, I allow users to match on a bucket like --source-uri gs://slsa-tooling_cloudbuild/source in the same way we allow source pinning without commit.

On the other hand, our SLSA tool has no distinction between leveling. Versions source is a fairly low level requirement, and GCB builds do not satisfy that. If we start to distinguish between requirements of different builders, than we also probably want a way to specify what level the builder is achieving.

@laurentsimon
Copy link
Contributor

that brings us back to #84 and #158

@ianlewis ianlewis added area:gcb Issue with the gcb verifier type:discussion A discussion or suggestion labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gcb Issue with the gcb verifier type:discussion A discussion or suggestion
Projects
None yet
Development

No branches or pull requests

3 participants