Skip to content

Commit 32123af

Browse files
committed
update
Signed-off-by: laurentsimon <[email protected]>
1 parent bb34cb7 commit 32123af

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

verifiers/utils/builder.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,10 @@ func IsValidJreleaserBuilderTag(ref string) error {
164164
languages := map[string]bool{
165165
"-java": true,
166166
}
167-
_, correctLanguage := languages[semver.Prerelease(pin)]
167+
_, validLanguage := languages[semver.Prerelease(pin)]
168168
if !semver.IsValid(pin) ||
169169
len(strings.Split(pin, ".")) != 3 ||
170-
!correctLanguage ||
170+
!validLanguage ||
171171
semver.Build(pin) != "" {
172172
return fmt.Errorf("%w: %s: not of the form vX.Y.Z-<language>", serrors.ErrorInvalidRef, pin)
173173
}

verifiers/utils/builder_test.go

-10
Original file line numberDiff line numberDiff line change
@@ -672,11 +672,6 @@ func Test_IsValidBuilderTag(t *testing.T) {
672672
ref: "refs/tags/v1",
673673
err: serrors.ErrorInvalidRef,
674674
},
675-
{
676-
name: "valid semver: no minor",
677-
ref: "refs/tags/v1",
678-
err: serrors.ErrorInvalidRef,
679-
},
680675
{
681676
name: "valid semver: pre-release",
682677
ref: "refs/tags/v1.2.3-rc.0",
@@ -792,11 +787,6 @@ func Test_IsValidJreleaserBuilderTag(t *testing.T) {
792787
ref: "refs/tags/v1-java",
793788
err: serrors.ErrorInvalidRef,
794789
},
795-
{
796-
name: "valid semver: no minor",
797-
ref: "refs/tags/v1-java",
798-
err: serrors.ErrorInvalidRef,
799-
},
800790
{
801791
name: "valid semver: pre-release",
802792
ref: "refs/tags/v1.2.3-rc.0+java",

0 commit comments

Comments
 (0)