File tree 2 files changed +2
-12
lines changed
2 files changed +2
-12
lines changed Original file line number Diff line number Diff line change @@ -164,10 +164,10 @@ func IsValidJreleaserBuilderTag(ref string) error {
164
164
languages := map [string ]bool {
165
165
"-java" : true ,
166
166
}
167
- _ , correctLanguage := languages [semver .Prerelease (pin )]
167
+ _ , validLanguage := languages [semver .Prerelease (pin )]
168
168
if ! semver .IsValid (pin ) ||
169
169
len (strings .Split (pin , "." )) != 3 ||
170
- ! correctLanguage ||
170
+ ! validLanguage ||
171
171
semver .Build (pin ) != "" {
172
172
return fmt .Errorf ("%w: %s: not of the form vX.Y.Z-<language>" , serrors .ErrorInvalidRef , pin )
173
173
}
Original file line number Diff line number Diff line change @@ -672,11 +672,6 @@ func Test_IsValidBuilderTag(t *testing.T) {
672
672
ref : "refs/tags/v1" ,
673
673
err : serrors .ErrorInvalidRef ,
674
674
},
675
- {
676
- name : "valid semver: no minor" ,
677
- ref : "refs/tags/v1" ,
678
- err : serrors .ErrorInvalidRef ,
679
- },
680
675
{
681
676
name : "valid semver: pre-release" ,
682
677
ref : "refs/tags/v1.2.3-rc.0" ,
@@ -792,11 +787,6 @@ func Test_IsValidJreleaserBuilderTag(t *testing.T) {
792
787
ref : "refs/tags/v1-java" ,
793
788
err : serrors .ErrorInvalidRef ,
794
789
},
795
- {
796
- name : "valid semver: no minor" ,
797
- ref : "refs/tags/v1-java" ,
798
- err : serrors .ErrorInvalidRef ,
799
- },
800
790
{
801
791
name : "valid semver: pre-release" ,
802
792
ref : "refs/tags/v1.2.3-rc.0+java" ,
You can’t perform that action at this time.
0 commit comments