Skip to content

[feature] Reduce latency during inclusion proof validation #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurentsimon opened this issue Aug 3, 2022 · 1 comment
Open

[feature] Reduce latency during inclusion proof validation #659

laurentsimon opened this issue Aug 3, 2022 · 1 comment
Assignees
Labels
type:feature New feature or request

Comments

@laurentsimon
Copy link
Collaborator

laurentsimon commented Aug 3, 2022

The log entry https://github.com/slsa-framework/slsa-github-generator/blob/main/signing/sigstore/rekor.go#L68 has the information for validating the inclusion proof, so we should be able to just do:

logEntry, err := cosign.TLogUploadInTotoAttestation(ctx, rekorClient, att.Bytes(), []byte(string(att.Cert())))
...
err := cosign.VerifyTLogEntry(ctx, rekorClient, &logEntry)

Something @bobcallaway pointed out.

@asraa assigning to you.

@laurentsimon laurentsimon added type:feature New feature or request status:triage Issue that has not been triaged labels Aug 3, 2022
@ianlewis ianlewis removed the status:triage Issue that has not been triaged label Aug 4, 2022
@asraa
Copy link
Collaborator

asraa commented Aug 5, 2022

I believe this is because we wanted the entry UUID and the TLogUploadInTotoAttestation func does not provide that.

We can just calculate it from the entry body.

@ianlewis ianlewis added this to the 2022 Stability improvements milestone Sep 21, 2022
@ianlewis ianlewis removed this from the 2022 Stability improvements milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants