Fix clippy warnings and update pre-commit plugin (#321)

Author: uklotzde

.pre-commit-config.yaml

@@ -44,7 +44,7 @@ repos:
       - id: codespell
         args: [--ignore-words=.codespellignore]
   - repo: https://github.com/sirosen/check-jsonschema
-    rev: 0.31.3
+    rev: 0.33.0
     hooks:
       - id: check-github-actions
       - id: check-github-workflows

src/codec/mod.rs

@@ -490,7 +490,7 @@ fn coil_to_bool(coil: u16) -> io::Result<bool> {
 
 #[cfg(any(test, feature = "rtu", feature = "tcp"))]
 fn packed_coils_size(coils: &[Coil]) -> usize {
-    (coils.len() + 7) / 8
+    coils.len().div_ceil(8)
 }
 
 #[cfg(any(test, feature = "rtu", feature = "tcp"))]
@@ -552,9 +552,9 @@ fn response_pdu_size(response: &Response) -> io::Result<usize> {
         ReadInputRegisters(data)
         | ReadHoldingRegisters(data)
         | ReadWriteMultipleRegisters(data) => 2 + data.len() * 2,
-        ReportServerId(_, _, ref data) => 3 + data.len(),
+        ReportServerId(_, _, data) => 3 + data.len(),
         MaskWriteRegister(_, _, _) => 7,
-        Custom(_, ref data) => 1 + data.len(),
+        Custom(_, data) => 1 + data.len(),
     };
     if size > MAX_PDU_SIZE {
         return Err(io::Error::new(

src/codec/rtu.rs

@@ -88,7 +88,7 @@ impl FrameDecoder {
         // Skip and record the first byte of the buffer
         {
             let first = buf.first().unwrap();
-            log::debug!("Dropped first byte: {:X?}", first);
+            log::debug!("Dropped first byte: {first:X?}");
             if self.dropped_bytes.len() >= MAX_FRAME_LEN {
                 log::error!(
                     "Giving up to decode frame after dropping {} byte(s): {:X?}",
@@ -293,7 +293,7 @@ impl Decoder for ClientCodec {
             .map(|pdu| Some(ResponseAdu { hdr, pdu }))
             .map_err(|err| {
                 // Unrecoverable error
-                log::error!("Failed to decode response PDU: {}", err);
+                log::error!("Failed to decode response PDU: {err}");
                 err
             })
     }
@@ -318,7 +318,7 @@ impl Decoder for ServerCodec {
             .map(|pdu| Some(RequestAdu { hdr, pdu }))
             .map_err(|err| {
                 // Unrecoverable error
-                log::error!("Failed to decode request PDU: {}", err);
+                log::error!("Failed to decode request PDU: {err}");
                 err
             })
     }

src/service/rtu.rs

@@ -54,7 +54,7 @@ where
     }
 
     async fn call(&mut self, req: Request<'_>) -> Result<Response> {
-        log::debug!("Call {:?}", req);
+        log::debug!("Call {req:?}");
 
         let req_function_code = req.function_code();
         let req_adu = self.next_request_adu(req);

src/service/tcp.rs

@@ -90,7 +90,7 @@ where
     }
 
     pub(crate) async fn call(&mut self, req: Request<'_>) -> Result<Response> {
-        log::debug!("Call {:?}", req);
+        log::debug!("Call {req:?}");
 
         let req_function_code = req.function_code();
         let req_adu = self.next_request_adu(req);