Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavelet squeeze is not GPU friendly #52

Closed
yl4070 opened this issue Mar 20, 2022 · 3 comments
Closed

Wavelet squeeze is not GPU friendly #52

yl4070 opened this issue Mar 20, 2022 · 3 comments

Comments

@yl4070
Copy link

yl4070 commented Mar 20, 2022

Hi, on my testing, wavelet_squeeze cause scalar indexing warning. And on benchmark, the it appears it would took almost 2s to complete such calculation. Is there any way to work around this?

X = rand(Float32, 16, 16, 16, 10) |> gpu
@btime wavelet_squeeze(X)
# 1.988s
@mloubout
Copy link
Member

wavelet_squeeze uses an external Wavelet transform librairy that doesn't support GPU and shouldn't be used for GPU cases. If you want to use networks and layer on GPU involving squeeze you should use our Harr implementation that is a custom implementation of the Wavelet transform with a Harr basis that supports GPU. Check Haar_squeeze and invHaar_unsqueeze

@yl4070
Copy link
Author

yl4070 commented Mar 20, 2022

Thanks. I wonder if this package is still in active development? Can I expect new feature/layer/network get implemented?

@mloubout
Copy link
Member

This package is still very active yes. We haven't come across much new networks/layers to add but we are still working with this package daily for our research and updates and improvement will be added as much as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants