Skip to content

Commit fbd9869

Browse files
committed
Remove native named captures from s-xregexp-methods.js so the tests work again in pre-ES2018 environments
1 parent b9802a9 commit fbd9869

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/spec/s-xregexp-methods.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -1257,13 +1257,13 @@ describe('XRegExp.replace()', function() {
12571257
});
12581258

12591259
it('should throw an exception for backreferences to unknown group names', function() {
1260-
expect(function() {XRegExp.replace('test', XRegExp('(?<test>t)', 'g'), ':${x}:');}).toThrowError(SyntaxError);
1261-
expect(function() {XRegExp.replace('test', XRegExp('(?<test>t)', 'g'), ':$<x>:');}).toThrowError(SyntaxError);
1260+
expect(function() {XRegExp.replace('test', XRegExp('(?<test>)'), ':${x}:');}).toThrowError(SyntaxError);
1261+
expect(function() {XRegExp.replace('test', XRegExp('(?<test>)'), ':$<x>:');}).toThrowError(SyntaxError);
12621262
});
12631263

12641264
it('should throw an exception for backreferences with leading or trailing spaces', function() {
1265-
expect(function() {XRegExp.replace('test', /(?<test>)/, '$< test>');}).toThrowError(SyntaxError);
1266-
expect(function() {XRegExp.replace('test', /(?<test>)/, '$<test >');}).toThrowError(SyntaxError);
1265+
expect(function() {XRegExp.replace('test', XRegExp('(?<test>)'), '$< test>');}).toThrowError(SyntaxError);
1266+
expect(function() {XRegExp.replace('test', XRegExp('(?<test>)'), '$<test >');}).toThrowError(SyntaxError);
12671267
});
12681268

12691269
});
@@ -1310,8 +1310,8 @@ describe('XRegExp.replace()', function() {
13101310

13111311
it('should throw an exception for backreferences to unknown group numbers when using named capture', function() {
13121312
expect(function() {XRegExp.replace('test', XRegExp('(?<n>t)'), '$<2>');}).toThrowError(SyntaxError);
1313-
// Native named capture introduced in ES2018
1314-
expect(function() {XRegExp.replace('test', /(?<n>t)/, '$<2>');}).toThrowError(SyntaxError);
1313+
// Native ES2018 named capture
1314+
//expect(function() {XRegExp.replace('test', /(?<n>t)/, '$<2>');}).toThrowError(SyntaxError);
13151315
});
13161316

13171317
it('should throw an exception for backreferences with leading or trailing spaces', function() {
@@ -1370,8 +1370,8 @@ describe('XRegExp.replace()', function() {
13701370

13711371
it('should throw an exception for backreferences to unknown group numbers when using named capture', function() {
13721372
expect(function() {XRegExp.replace('test', XRegExp('(?<n>t)'), '$2');}).toThrowError(SyntaxError);
1373-
// Native named capture introduced in ES2018
1374-
expect(function() {XRegExp.replace('test', /(?<n>t)/, '$2');}).toThrowError(SyntaxError);
1373+
// Native ES2018 named capture
1374+
//expect(function() {XRegExp.replace('test', /(?<n>t)/, '$2');}).toThrowError(SyntaxError);
13751375
});
13761376

13771377
it('should throw an exception for unrecognized tokens', function() {

0 commit comments

Comments
 (0)