Skip to content

Numeric Ids vs Guids #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smellogrand opened this issue Dec 5, 2018 · 6 comments
Closed

Numeric Ids vs Guids #127

smellogrand opened this issue Dec 5, 2018 · 6 comments
Assignees

Comments

@smellogrand
Copy link

Great work, really appreciate it.
One suggestion, as many old timers using IS3/IS4 in real life projects I have used Guids for ids on entities and was somehow surprised in seeing that your base implemantation is instead using numeric Ids.
Of course you have provided good documentation on how to change things to support Guids, thank you for that, but, as I assume you and colleagues also have experience in IS4 I wonder what is the reason of your preferred choice.
In general i believe Guids are better also for slalability and merging of istances, and most benchmark show that in SQL Server newsequentialid() is even faster than autonumber.
Thanks again for your effort, very nice and useful.

sergio, Italy

@skoruba skoruba self-assigned this Dec 5, 2018
@skoruba
Copy link
Owner

skoruba commented Dec 5, 2018

@smellogrand Thanks for your suggestion, I will consider to use guid as default.

@Seaear
Copy link
Contributor

Seaear commented Dec 5, 2018

@smellogrand
https://github.com/Seaear/IdentityServer4.Admin/tree/pk-guid

@skoruba
Copy link
Owner

skoruba commented Jan 27, 2019

I've changed the int to string (guid) - here is preview:
https://github.com/skoruba/IdentityServer4.Admin/tree/feature/identity-default-key

@smellogrand
Copy link
Author

Thanks, I believe this is more in line with recent patterns.
I suggest changing the wron title I inserted originally from mimeric to numeric.

thanks for your very useful development

sergio

@skoruba skoruba changed the title mimeric Ids vs Guids Numeric Ids vs Guids Jan 29, 2019
@skoruba skoruba mentioned this issue Apr 4, 2019
@skoruba
Copy link
Owner

skoruba commented Apr 4, 2019

Done on master. Please check new release.
Thanks!

@skoruba skoruba closed this as completed Apr 4, 2019
@smellogrand
Copy link
Author

Thanks my friend, you are a good guy, I will check it by tomorrow and give feedback.
Hope someday to return the courtesy vistiting you in Prague. For sure you deserve more than a good beer. I will let you choose a good restaurant.
stay well and keep up your good work, very helpful for many of us.
bye, sergio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants