fix: git checkout before checking Step #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsese
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Hmm not sure if anything in particular isn't working or is broken without this change (it looks like https://github.com/skills/test-with-actions is the only course that uses base_branch_name) but seems fine to me /cc @heiskr just a heads up I'm merging this
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
also thanks as always for the contribution 🙇 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The if statement checking that we are on FROM_STEP should be run after the
git checkout $BASE_BRANCH_NAMEcommand.Changes
Swap the order
Closes: #21
Task list