Merge bitcoin#9087: RPC: why not give more details when "generate" fails?

MarcoFalke · MarcoFalke · commit 924de0bd75a7 · 2016-11-08T15:55:53.000+01:00
1adf82a RPC: Give more details when "generate" fails (Jorge Timón)
diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp
@@ -133,7 +133,7 @@ UniValue generateBlocks(boost::shared_ptr<CReserveScript> coinbaseScript, int nG
         }
         CValidationState state;
         if (!ProcessNewBlock(state, Params(), NULL, pblock, true, NULL, false))
-            throw JSONRPCError(RPC_INTERNAL_ERROR, "ProcessNewBlock, block not accepted");
+            throw JSONRPCError(RPC_INTERNAL_ERROR, strprintf("ProcessNewBlock: block not accepted: %s", FormatStateMessage(state)));
         ++nHeight;
         blockHashes.push_back(pblock->GetHash().GetHex());
 

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ UniValue generateBlocks(boost::shared_ptr<CReserveScript> coinbaseScript, int nG`
`133`	`133`	`}`
`134`	`134`	`CValidationState state;`
`135`	`135`	`if (!ProcessNewBlock(state, Params(), NULL, pblock, true, NULL, false))`
`136`		`- throw JSONRPCError(RPC_INTERNAL_ERROR, "ProcessNewBlock, block not accepted");`
	`136`	`+ throw JSONRPCError(RPC_INTERNAL_ERROR, strprintf("ProcessNewBlock: block not accepted: %s", FormatStateMessage(state)));`
`137`	`137`	`++nHeight;`
`138`	`138`	`blockHashes.push_back(pblock->GetHash().GetHex());`
`139`	`139`