Suppress -Wunused-parameter when building for coverage analysis

hebasto · hebasto · commit 4429a8c218d7 · 2023-03-14T20:03:42.000Z
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -147,7 +147,7 @@ else()
 endif()
 
 # Define custom "Coverage" build type.
-set(CMAKE_C_FLAGS_COVERAGE "${CMAKE_C_FLAGS_RELWITHDEBINFO} -O0 -DCOVERAGE=1 --coverage -Wno-unused-parameter" CACHE STRING
+set(CMAKE_C_FLAGS_COVERAGE "${CMAKE_C_FLAGS_RELWITHDEBINFO} -O0 -DCOVERAGE=1 --coverage" CACHE STRING
   "Flags used by the C compiler during \"Coverage\" builds."
   FORCE
 )
diff --git a/src/ecmult_impl.h b/src/ecmult_impl.h
@@ -115,6 +115,7 @@ static void secp256k1_ecmult_odd_multiples_table(int n, secp256k1_ge *pre_a, sec
 }
 
 #define SECP256K1_ECMULT_TABLE_VERIFY(n,w) \
+    (void)w; \
     VERIFY_CHECK(((n) & 1) == 1); \
     VERIFY_CHECK((n) >= -((1 << ((w)-1)) - 1)); \
     VERIFY_CHECK((n) <=  ((1 << ((w)-1)) - 1));

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ else()`
`147`	`147`	`endif()`
`148`	`148`
`149`	`149`	`# Define custom "Coverage" build type.`
`150`		`-set(CMAKE_C_FLAGS_COVERAGE "${CMAKE_C_FLAGS_RELWITHDEBINFO} -O0 -DCOVERAGE=1 --coverage -Wno-unused-parameter" CACHE STRING`
	`150`	`+set(CMAKE_C_FLAGS_COVERAGE "${CMAKE_C_FLAGS_RELWITHDEBINFO} -O0 -DCOVERAGE=1 --coverage" CACHE STRING`
`151`	`151`	`"Flags used by the C compiler during \"Coverage\" builds."`
`152`	`152`	`FORCE`
`153`	`153`	`)`
Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,7 @@ static void secp256k1_ecmult_odd_multiples_table(int n, secp256k1_ge *pre_a, sec`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`#define SECP256K1_ECMULT_TABLE_VERIFY(n,w) \`
	`118`	`+ (void)w; \`
`118`	`119`	`VERIFY_CHECK(((n) & 1) == 1); \`
`119`	`120`	`VERIFY_CHECK((n) >= -((1 << ((w)-1)) - 1)); \`
`120`	`121`	`VERIFY_CHECK((n) <= ((1 << ((w)-1)) - 1));`