Skip to content

Commit 1ebf640

Browse files
author
MarcoFalke
committed
Merge bitcoin#17647: lcov: filter depends from coverage reports
f736f69 lcov: filter /usr/lib64 from coverage report (nijynot) a5a705b lcov: filter depends from coverage report (nijynot) Pull request description: If you build the binaries with the `depends` folder and then generate coverage reports with `make cov`, `depends` will be included in the coverage reports. Coverage of the dependencies are not that interesting and should be filtered. ACKs for top commit: laanwj: code review ACK f736f69 MarcoFalke: ACK f736f69 🐇 Tree-SHA512: 57c3e09f32e71523afff6ddc4f92bc35ab7b783f26f7a7380ae7556222954111cccce4c6dbc99305c424818f91e15bf5fe3532a7dca1daaa8ad71315d1dd857c
2 parents 91559da + f736f69 commit 1ebf640

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

Makefile.am

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ $(OSX_APP)/Contents/PkgInfo:
9999

100100
$(OSX_APP)/Contents/Resources/empty.lproj:
101101
$(MKDIR_P) $(@D)
102-
@touch $@
102+
@touch $@
103103

104104
$(OSX_APP)/Contents/Info.plist: $(OSX_PLIST)
105105
$(MKDIR_P) $(@D)
@@ -189,7 +189,16 @@ $(BITCOIN_WALLET_BIN): FORCE
189189
$(MAKE) -C src $(@F)
190190

191191
if USE_LCOV
192-
LCOV_FILTER_PATTERN=-p "/usr/include/" -p "/usr/lib/" -p "src/leveldb/" -p "src/bench/" -p "src/univalue" -p "src/crypto/ctaes" -p "src/secp256k1"
192+
LCOV_FILTER_PATTERN = \
193+
-p "/usr/include/" \
194+
-p "/usr/lib/" \
195+
-p "/usr/lib64/" \
196+
-p "src/leveldb/" \
197+
-p "src/bench/" \
198+
-p "src/univalue" \
199+
-p "src/crypto/ctaes" \
200+
-p "src/secp256k1" \
201+
-p "depends"
193202

194203
baseline.info:
195204
$(LCOV) -c -i -d $(abs_builddir)/src -o $@
@@ -321,4 +330,3 @@ clean-local: clean-docs
321330
rm -rf coverage_percent.txt test_bitcoin.coverage/ total.coverage/ test/tmp/ cache/ $(OSX_APP)
322331
rm -rf test/functional/__pycache__ test/functional/test_framework/__pycache__ test/cache share/rpcauth/__pycache__
323332
rm -rf osx_volname dist/ dpi36.background.tiff dpi72.background.tiff
324-

0 commit comments

Comments
 (0)