Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use knip instead of unimported #2637

Open
mroderick opened this issue Feb 10, 2025 · 2 comments · May be fixed by #2650
Open

Use knip instead of unimported #2637

mroderick opened this issue Feb 10, 2025 · 2 comments · May be fixed by #2650
Assignees
@abidta
Labels
good first issue Help wanted

Comments

@mroderick
Copy link
Member

In #2636 we removed unimported, because it had been archived.

The author recommends using knip instead.

Let's implement knip and use it for finding unused files and dependencies.
@abidta
Copy link

abidta commented Mar 18, 2025

I'd like to work on this, could you assign it to me?

@fatso83
Copy link
Contributor

fatso83 commented Mar 18, 2025

Sure, go ahead.

abidta added a commit to abidta/sinon that referenced this issue Mar 20, 2025
@abidta
chore: replace unimported with knip and update workflow
8bac331 
- Added knip as the recommended replacement.

- Integrated knip into the workflow file for automated checks.

Closes sinonjs#2637
@abidta abidta linked a pull request Mar 20, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abidta abidta

Labels
good first issue Help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace unimported with knip and update workflow abidta/sinon
3 participants
@mroderick @fatso83 @abidta