Skip to content

Warn users when https.request is modified #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
szmarczak opened this issue Aug 21, 2020 · 2 comments
Closed
1 task done

Warn users when https.request is modified #1415

szmarczak opened this issue Aug 21, 2020 · 2 comments
Labels
enhancement This change will extend Got features wontfix The issue cannot be fixed on Got side
Milestone
Got v11.7.0

Comments

@szmarczak
Copy link
Collaborator

What problem are you trying to solve?

MONEI/Shopify-api-node#385 (comment)

Describe the feature

Simply throw in that case. Add an option to disable the check.

Checklist

  • I have read the documentation and made sure this feature doesn't already exist.
@szmarczak szmarczak added enhancement This change will extend Got features ✭ help wanted ✭ labels Aug 21, 2020
@szmarczak
Copy link
Collaborator Author

/cc @lpinca

@szmarczak szmarczak added this to the Got v11.7.0 milestone Sep 17, 2020
@szmarczak szmarczak added wontfix The issue cannot be fixed on Got side and removed ✭ help wanted ✭ labels Sep 18, 2020
@szmarczak
Copy link
Collaborator Author

MONEI/Shopify-api-node#385 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This change will extend Got features wontfix The issue cannot be fixed on Got side
Projects
None yet
Milestone
Got v11.7.0
Development

No branches or pull requests
1 participant
@szmarczak