Tweaks

Author: sindresorhus

.github/workflows/main.yml

@@ -14,7 +14,6 @@ jobs:
         node-version:
           - 18
           - 16
-          - 14
         os:
           # Ubuntu fails and I don't have time to look into it. PR welcome.
           # - ubuntu-latest

documentation/2-options.md

@@ -215,8 +215,6 @@ await got('https://httpbin.org/anything');
 
 You can abort the `request` using [`AbortController`](https://developer.mozilla.org/en-US/docs/Web/API/AbortController).
 
-*Requires Node.js 16 or later.*
-
 ```js
 import got from 'got';
 

documentation/tips.md

@@ -176,8 +176,8 @@ If you're using proxies, you may run into connection issues.\
 One way out is to disable proxies when retrying. The solution for the Stream API looks like this:
 
 ```js
-import https from 'https';
-import fs from 'fs';
+import https from 'node:https';
+import fs from 'node:fs';
 import got from 'got';
 
 class MyAgent extends https.Agent {

package.json

@@ -138,7 +138,6 @@
 			"@typescript-eslint/no-empty-function": "off",
 			"n/no-deprecated-api": "off",
 			"@typescript-eslint/no-implicit-any-catch": "off",
-			"unicorn/prefer-node-protocol": "off",
 			"ava/assertion-arguments": "off",
 			"@typescript-eslint/no-unsafe-member-access": "off",
 			"@typescript-eslint/no-unsafe-return": "off",

readme.md

@@ -94,7 +94,7 @@ npm install got
 
 **Warning:** This package is native [ESM](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) and no longer provides a CommonJS export. If your project uses CommonJS, you will have to [convert to ESM](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c) or use the [dynamic `import()`](https://v8.dev/features/dynamic-import) function. Please don't open issues for questions regarding CommonJS / ESM.
 
-**Got v11 (the previous major version) is no longer maintained and we will not accept any backport requests.**
+**Got v11 is no longer maintained and we will not accept any backport requests.**
 
 ## Take a peek
 

source/core/index.ts

@@ -276,8 +276,9 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 				abort();
 			} else {
 				this.options.signal.addEventListener('abort', abort);
+
 				this._removeListeners = () => {
-					this.options.signal.removeEventListener('abort', abort);
+					this.options.signal?.removeEventListener('abort', abort);
 				};
 			}
 		}

source/core/options.ts

@@ -1499,8 +1499,6 @@ export default class Options {
 	/**
 	You can abort the `request` using [`AbortController`](https://developer.mozilla.org/en-US/docs/Web/API/AbortController).
 
-	*Requires Node.js 16 or later.*
-
 	@example
 	```
 	import got from 'got';
@@ -1516,13 +1514,11 @@ export default class Options {
 	}, 100);
 	```
 	*/
-	// TODO: Replace `any` with `AbortSignal` when targeting Node 16.
-	get signal(): any | undefined {
+	get signal(): AbortSignal | undefined {
 		return this._internals.signal;
 	}
 
-	// TODO: Replace `any` with `AbortSignal` when targeting Node 16.
-	set signal(value: any | undefined) {
+	set signal(value: AbortSignal | undefined) {
 		assert.object(value);
 
 		this._internals.signal = value;

test/abort.ts

@@ -1,7 +1,7 @@
-import process from 'process';
-import {EventEmitter} from 'events';
-import {Readable as ReadableStream} from 'stream';
-import {pipeline as streamPipeline} from 'stream/promises';
+import process from 'node:process';
+import {EventEmitter} from 'node:events';
+import {Readable as ReadableStream} from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import test from 'ava';
 import delay from 'delay';
 import {pEvent} from 'p-event';

test/agent.ts

@@ -1,5 +1,5 @@
-import {Agent as HttpAgent} from 'http';
-import {Agent as HttpsAgent} from 'https';
+import {Agent as HttpAgent} from 'node:http';
+import {Agent as HttpsAgent} from 'node:https';
 import test from 'ava';
 import sinon from 'sinon';
 import type {Constructor} from 'type-fest';

test/arguments.ts

@@ -1,4 +1,4 @@
-import {parse} from 'url';
+import {parse} from 'node:url';
 import test from 'ava';
 import type {Handler} from 'express';
 import {pEvent} from 'p-event';

test/cache.ts

@@ -1,9 +1,9 @@
-import {Buffer} from 'buffer';
-import {promisify} from 'util';
-import {Readable as ReadableStream} from 'stream';
-import {Agent} from 'http';
-import {gzip} from 'zlib';
-import process from 'process';
+import {Buffer} from 'node:buffer';
+import {promisify} from 'node:util';
+import {Readable as ReadableStream} from 'node:stream';
+import {Agent} from 'node:http';
+import {gzip} from 'node:zlib';
+import process from 'node:process';
 import test from 'ava';
 import {pEvent} from 'p-event';
 import getStream from 'get-stream';
@@ -561,7 +561,8 @@ test.failing('revalidated compressed responses are retrieved from cache', withSe
 	});
 });
 
-test.failing('revalidated uncompressed responses from github are retrieved from cache', async t => {
+// eslint-disable-next-line ava/no-skip-test -- Unreliable
+test.skip('revalidated uncompressed responses from github are retrieved from cache', async t => {
 	const client = got.extend({
 		cache: new Map(),
 		cacheOptions: {shared: false},
@@ -590,7 +591,8 @@ test.failing('revalidated uncompressed responses from github are retrieved from
 	});
 });
 
-test.failing('revalidated compressed responses from github are retrieved from cache', async t => {
+// eslint-disable-next-line ava/no-skip-test -- Unreliable
+test.skip('revalidated compressed responses from github are retrieved from cache', async t => {
 	const client = got.extend({
 		cache: new Map(),
 		cacheOptions: {shared: false},

test/cancel.ts

@@ -1,7 +1,7 @@
-import process from 'process';
-import {EventEmitter} from 'events';
-import {Readable as ReadableStream} from 'stream';
-import {pipeline as streamPipeline} from 'stream/promises';
+import process from 'node:process';
+import {EventEmitter} from 'node:events';
+import {Readable as ReadableStream} from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import test from 'ava';
 import delay from 'delay';
 import {pEvent} from 'p-event';

test/cookies.ts

@@ -1,4 +1,4 @@
-import net from 'net';
+import net from 'node:net';
 import test from 'ava';
 import toughCookie from 'tough-cookie';
 import delay from 'delay';

test/create.ts

@@ -3,7 +3,7 @@ import {
 	request as httpRequest,
 	type IncomingMessage,
 	type RequestOptions,
-} from 'http';
+} from 'node:http';
 import test from 'ava';
 import is from '@sindresorhus/is';
 import type {Handler} from 'express';

test/encoding.ts

@@ -1,4 +1,4 @@
-import {Buffer} from 'buffer';
+import {Buffer} from 'node:buffer';
 import test from 'ava';
 import withServer from './helpers/with-server.js';
 

test/error.ts

@@ -1,9 +1,9 @@
-import {Buffer} from 'buffer';
-import {promisify} from 'util';
-import net from 'net';
-import http from 'http';
-import stream from 'stream';
-import {pipeline as streamPipeline} from 'stream/promises';
+import {Buffer} from 'node:buffer';
+import {promisify} from 'node:util';
+import net from 'node:net';
+import http from 'node:http';
+import stream from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import test from 'ava';
 import getStream from 'get-stream';
 import is from '@sindresorhus/is';

test/gzip.ts

@@ -1,6 +1,6 @@
-import {Buffer} from 'buffer';
-import {promisify} from 'util';
-import zlib from 'zlib';
+import {Buffer} from 'node:buffer';
+import {promisify} from 'node:util';
+import zlib from 'node:zlib';
 import test from 'ava';
 import getStream from 'get-stream';
 import {ReadError, type HTTPError} from '../source/index.js';

test/headers.ts

@@ -1,7 +1,7 @@
-import process from 'process';
-import {Buffer} from 'buffer';
-import fs from 'fs';
-import path from 'path';
+import process from 'node:process';
+import {Buffer} from 'node:buffer';
+import fs from 'node:fs';
+import path from 'node:path';
 import test from 'ava';
 import type {Handler} from 'express';
 import FormData from 'form-data';

test/helpers/create-http-test-server.ts

@@ -1,5 +1,5 @@
-import http from 'http';
-import type net from 'net';
+import http from 'node:http';
+import type net from 'node:net';
 import express, {type Express, type NextFunction} from 'express';
 import pify from 'pify';
 import bodyParser from 'body-parser';

test/helpers/create-https-test-server.ts

@@ -1,7 +1,7 @@
-import type {Buffer} from 'buffer';
-import https from 'https';
-import type net from 'net';
-import type {SecureContextOptions} from 'tls';
+import type {Buffer} from 'node:buffer';
+import https from 'node:https';
+import type net from 'node:net';
+import type {SecureContextOptions} from 'node:tls';
 import express from 'express';
 import pify from 'pify';
 import pem from 'pem';

test/helpers/slow-data-stream.ts

@@ -1,4 +1,4 @@
-import {Readable} from 'stream';
+import {Readable} from 'node:stream';
 import type {Clock} from '@sinonjs/fake-timers';
 import delay from 'delay';
 

test/helpers/types.ts

@@ -1,4 +1,4 @@
-import type {Server} from 'http';
+import type {Server} from 'node:http';
 // @ts-expect-error Fails to locate ../types/create-test-server/index.d.ts
 import type {TestServer} from 'create-test-server';
 

test/helpers/with-server.ts

@@ -1,5 +1,5 @@
-import http from 'http';
-import {promisify} from 'util';
+import http from 'node:http';
+import {promisify} from 'node:util';
 import type {ExecutionContext, Macro} from 'ava';
 import is from '@sindresorhus/is';
 import {temporaryFile} from 'tempy';

test/hooks.ts

@@ -1,5 +1,5 @@
-import {Buffer} from 'buffer';
-import {Agent as HttpAgent} from 'http';
+import {Buffer} from 'node:buffer';
+import {Agent as HttpAgent} from 'node:http';
 import test from 'ava';
 import nock from 'nock';
 import getStream from 'get-stream';

test/http.ts

@@ -1,8 +1,8 @@
-import process from 'process';
-import {Buffer} from 'buffer';
-import {STATUS_CODES, Agent} from 'http';
-import os from 'os';
-import {isIPv4, isIPv6, isIP} from 'net';
+import process from 'node:process';
+import {Buffer} from 'node:buffer';
+import {STATUS_CODES, Agent} from 'node:http';
+import os from 'node:os';
+import {isIPv4, isIPv6, isIP} from 'node:net';
 import test from 'ava';
 import type {Handler} from 'express';
 import nock from 'nock';

test/https.ts

@@ -1,5 +1,5 @@
-import process from 'process';
-import tls, {type DetailedPeerCertificate} from 'tls';
+import process from 'node:process';
+import tls, {type DetailedPeerCertificate} from 'node:tls';
 import test from 'ava';
 import {pEvent} from 'p-event';
 import pify from 'pify';

test/pagination.ts

@@ -1,4 +1,4 @@
-import {Buffer} from 'buffer';
+import {Buffer} from 'node:buffer';
 import test from 'ava';
 import delay from 'delay';
 import getStream from 'get-stream';

test/post.ts

@@ -1,10 +1,10 @@
-import process from 'process';
-import {Buffer} from 'buffer';
-import stream from 'stream';
-import {pipeline as streamPipeline} from 'stream/promises';
-import fs from 'fs';
-import fsPromises from 'fs/promises';
-import path from 'path';
+import process from 'node:process';
+import {Buffer} from 'node:buffer';
+import stream from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
+import fs from 'node:fs';
+import fsPromises from 'node:fs/promises';
+import path from 'node:path';
 import test from 'ava';
 import delay from 'delay';
 import {pEvent} from 'p-event';

test/progress.ts

@@ -1,9 +1,9 @@
-import process from 'process';
-import {Buffer} from 'buffer';
-import {promisify} from 'util';
-import stream from 'stream';
+import process from 'node:process';
+import {Buffer} from 'node:buffer';
+import {promisify} from 'node:util';
+import stream from 'node:stream';
 import {pipeline as streamPipeline} from 'node:stream/promises';
-import fs from 'fs';
+import fs from 'node:fs';
 // @ts-expect-error Fails to find slow-stream/index.d.ts
 import SlowStream from 'slow-stream';
 import getStream from 'get-stream';

test/promise.ts

@@ -1,6 +1,6 @@
-import {Buffer} from 'buffer';
-import {ReadStream} from 'fs';
-import {ClientRequest, IncomingMessage} from 'http';
+import {Buffer} from 'node:buffer';
+import {ReadStream} from 'node:fs';
+import {ClientRequest, IncomingMessage} from 'node:http';
 import test from 'ava';
 import {type Response, CancelError} from '../source/index.js';
 import withServer from './helpers/with-server.js';

test/redirects.ts

@@ -1,4 +1,4 @@
-import {Buffer} from 'buffer';
+import {Buffer} from 'node:buffer';
 import test from 'ava';
 import type {Handler} from 'express';
 import nock from 'nock';

test/response-parse.ts

@@ -1,4 +1,4 @@
-import {Buffer} from 'buffer';
+import {Buffer} from 'node:buffer';
 import test from 'ava';
 import type {Handler} from 'express';
 import getStream from 'get-stream';

test/retry.ts

@@ -1,8 +1,8 @@
-import process from 'process';
-import {EventEmitter} from 'events';
-import {PassThrough as PassThroughStream} from 'stream';
-import type {Socket} from 'net';
-import http from 'http';
+import process from 'node:process';
+import {EventEmitter} from 'node:events';
+import {PassThrough as PassThroughStream} from 'node:stream';
+import type {Socket} from 'node:net';
+import http from 'node:http';
 import test from 'ava';
 import is from '@sindresorhus/is';
 import type {Handler} from 'express';

test/stream.ts

@@ -1,9 +1,9 @@
-import process from 'process';
-import {Buffer} from 'buffer';
-import fs from 'fs';
-import {Agent as HttpAgent} from 'http';
-import stream, {Readable as ReadableStream, Writable} from 'stream';
-import {pipeline as streamPipeline} from 'stream/promises';
+import process from 'node:process';
+import {Buffer} from 'node:buffer';
+import fs from 'node:fs';
+import {Agent as HttpAgent} from 'node:http';
+import stream, {Readable as ReadableStream, Writable} from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import {Readable as Readable2} from 'readable-stream';
 import test from 'ava';
 import type {Handler} from 'express';

test/timeout.ts

@@ -1,9 +1,9 @@
-import process from 'process';
-import {EventEmitter} from 'events';
-import stream, {PassThrough as PassThroughStream} from 'stream';
-import {pipeline as streamPipeline} from 'stream/promises';
-import http from 'http';
-import net from 'net';
+import process from 'node:process';
+import {EventEmitter} from 'node:events';
+import stream, {PassThrough as PassThroughStream} from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
+import http from 'node:http';
+import net from 'node:net';
 import getStream from 'get-stream';
 import test from 'ava';
 import delay from 'delay';

test/types/create-test-server/index.d.ts

@@ -1,4 +1,4 @@
-import type {Buffer} from 'buffer';
+import type {Buffer} from 'node:buffer';
 
 declare module 'create-test-server' {
 	import type {Express} from 'express';