Skip to content

Commit 3df0ed1

Browse files
authored
Remove an unnecessary dependency (#458)
1 parent 1e4e8df commit 3df0ed1

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

browser.js

+11-12
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict';
22
const {ReadableWebToNodeStream} = require('readable-web-to-node-stream');
3-
const toBuffer = require('typedarray-to-buffer');
43
const core = require('./core');
54

65
async function fromStream(stream) {
@@ -11,25 +10,25 @@ async function fromStream(stream) {
1110
}
1211

1312
async function fromBlob(blob) {
14-
const buffer = await convertBlobToBuffer(blob);
15-
return core.fromBuffer(buffer);
13+
const buffer = await blobToArrayBuffer(blob);
14+
return core.fromBuffer(Buffer.from(buffer));
1615
}
1716

1817
/**
19-
Convert Web API File to Node Buffer.
18+
Convert Blobs to ArrayBuffer.
2019
@param {Blob} blob - Web API Blob.
21-
@returns {Promise<Buffer>}
20+
@returns {Promise<ArrayBuffer>}
2221
*/
23-
function convertBlobToBuffer(blob) {
22+
function blobToArrayBuffer(blob) {
23+
if (blob.arrayBuffer) {
24+
return blob.arrayBuffer();
25+
}
26+
27+
// TODO: Remove when stop supporting older environments
2428
return new Promise((resolve, reject) => {
2529
const fileReader = new FileReader();
2630
fileReader.addEventListener('loadend', event => {
27-
let data = event.target.result;
28-
if (data instanceof ArrayBuffer) {
29-
data = toBuffer(new Uint8Array(event.target.result));
30-
}
31-
32-
resolve(data);
31+
resolve(event.target.result);
3332
});
3433

3534
fileReader.addEventListener('error', event => {

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,7 @@
197197
"dependencies": {
198198
"readable-web-to-node-stream": "^3.0.0",
199199
"strtok3": "^6.0.3",
200-
"token-types": "^2.0.0",
201-
"typedarray-to-buffer": "^3.1.5"
200+
"token-types": "^2.0.0"
202201
},
203202
"xo": {
204203
"envs": [

0 commit comments

Comments
 (0)