fix: improve EXIF date parsing and add comprehensive test cases

Author: simulot

internal/exif/direct.go

@@ -177,11 +177,12 @@ func readDateTime(x *exif.Exif, dateTag exif.FieldName, subSecTag exif.FieldName
 }
 
 func parseExifTime(date string, local *time.Location) (time.Time, error) {
+	date = strings.TrimSpace(date)
 	var year, month, day, hour, minutes, sec, milli int
 	date = strings.ReplaceAll(date, "-", ":")
 	date = strings.ReplaceAll(date, "/", ":")
 	_, err := fmt.Sscanf(date, "%d:%d:%d %d:%d:%d.%d", &year, &month, &day, &hour, &minutes, &sec, &milli)
-	if err != nil || year < 1900 || month == 0 || day == 0 {
+	if (err != nil && err.Error() != "unexpected EOF") || year < 1900 || month == 0 || day == 0 {
 		return time.Time{}, fmt.Errorf("invalid date format")
 	}
 	d := time.Date(year, time.Month(month), day, hour, minutes, sec, milli*int(time.Millisecond), local)

internal/exif/direct_test.go

@@ -90,19 +90,68 @@ func Test_parseExifTime(t *testing.T) {
 		wantErr  bool
 	}{
 		{
-			name:     "valid date with different separators  in local timezone",
+			name:     "valid date with different separators in local timezone",
 			date:     "2023-10-06 08:30:00",
 			location: time.Local,
 			want:     time.Date(2023, 10, 6, 8, 30, 0, 0, time.Local),
 			wantErr:  false,
 		},
 		{
-			name:     "valid date with milliseconds  in local timezone",
+			name:     "valid date with milliseconds in local timezone",
 			date:     "2023-10-06 08:30:00.123",
 			location: time.Local,
 			want:     time.Date(2023, 10, 6, 8, 30, 0, int(123*time.Millisecond), time.Local),
 			wantErr:  false,
 		},
+		{
+			name:     "valid date with different separators in UTC timezone",
+			date:     "2023-10-06 08:30:00",
+			location: time.UTC,
+			want:     time.Date(2023, 10, 6, 8, 30, 0, 0, time.UTC),
+			wantErr:  false,
+		},
+		{
+			name:     "valid date with milliseconds in UTC timezone",
+			date:     "2023/10/06 08:30:00.123",
+			location: time.UTC,
+			want:     time.Date(2023, 10, 6, 8, 30, 0, int(123*time.Millisecond), time.UTC),
+			wantErr:  false,
+		},
+		{
+			name:     "date format with different separators",
+			date:     "2023/10/06 08:30:00",
+			location: time.Local,
+			want:     time.Date(2023, 10, 6, 8, 30, 0, 0, time.Local),
+			wantErr:  false,
+		},
+		{
+			name:     "date format with milliseconds",
+			date:     "2023/10/06 08:30:00.123",
+			location: time.Local,
+			want:     time.Date(2023, 10, 6, 8, 30, 0, int(123*time.Millisecond), time.Local),
+			wantErr:  false,
+		},
+		{
+			name:     "empty date string",
+			date:     "",
+			location: time.Local,
+			want:     time.Time{},
+			wantErr:  true,
+		},
+		{
+			name:     "date string with extra spaces",
+			date:     "  2023-10-06 08:30:00  ",
+			location: time.Local,
+			want:     time.Date(2023, 10, 6, 8, 30, 0, 0, time.Local),
+			wantErr:  false,
+		},
+		{
+			name:     "date string with extra spaces and milliseconds",
+			date:     "  2023-10-06 08:30:00.123  ",
+			location: time.Local,
+			want:     time.Date(2023, 10, 6, 8, 30, 0, int(123*time.Millisecond), time.Local),
+			wantErr:  false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {