Fix #25 (#31)

* Add test case

* Add max attempts at wrapping

* Successful generation

* Some cleanup

Author: simonhamp

src/Interfaces/Box.php

@@ -4,10 +4,11 @@
 
 use Intervention\Image\Geometry\Point;
 use Intervention\Image\Interfaces\ImageInterface;
+use SimonHamp\TheOg\Layout\Position;
 
 interface Box
 {
-    public function anchor(): Point;
+    public function anchor(?Position $position): Point;
 
     public function name(string $name): static;
 

src/Layout/TextBox.php

@@ -8,6 +8,7 @@
 use Intervention\Image\Drivers\Imagick\Driver as ImagickDriver;
 use Intervention\Image\Interfaces\ColorInterface;
 use Intervention\Image\Interfaces\ImageInterface;
+use Intervention\Image\Interfaces\SpecializedInterface;
 use Intervention\Image\Modifiers\TextModifier;
 use Intervention\Image\Typography\FontFactory;
 use Intervention\Image\Typography\TextBlock;
@@ -78,7 +79,7 @@ protected function getPrerenderedBox(): Rectangle
         return $this->getFinalTextBox($modifier);
     }
 
-    protected function generateModifier(string $text, Point $position = new Point()): CustomTextModifier
+    protected function generateModifier(string $text, Point $position = new Point()): SpecializedInterface
     {
         return CustomTextModifier::buildSpecialized(
             new TextModifier(
@@ -131,7 +132,9 @@ protected function getFinalTextBox(CustomTextModifier &$modifier): Rectangle
         $text = $this->text;
         $renderedBox = $this->getRenderedBoxForText($text, $modifier);
 
-        while (! $this->doesTextFitInBox($renderedBox)) {
+        $attempts = 0;
+
+        while (! $this->doesTextFitInBox($renderedBox) && $attempts < 10) {
             if ($renderedBox->width() > $this->box->width()) {
                 $text = wordwrap($text, intval(floor($this->box->width() / ($modifier->boxSize('M')->width() / 1.8))));
                 $renderedBox = $this->getRenderedBoxForText($text, $modifier);
@@ -150,6 +153,8 @@ protected function getFinalTextBox(CustomTextModifier &$modifier): Rectangle
             }
 
             $modifier = $this->generateModifier($text, $modifier->position);
+
+            $attempts++;
         }
 
         return $renderedBox;

tests/Integration/ImageTest.php

@@ -201,5 +201,12 @@ public static function snapshotImages(): iterable
                 ->title('Simone Hampstead'),
             'avatar-too-small',
         ];
+
+        yield 'tricky title truncation' => [
+            (new Image())
+                ->layout(new GitHubBasic)
+                ->title('Adding Unique Field to MySQL Table With Existing Records'),
+            'tricky-title-truncation',
+        ];
     }
 }