Make N+1 bin optional in histogram #1831
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the same issue we had with the heatmap vis: the x axis needs to go up to the right-hand edge of the last bin; otherwise we can't compute the width of the last bar and we get a
NaN
width warning in the browser console.This PR makes the extra value in the
bins
array optional. If it's not present, we assume we want the same step value as between the last and second last bins.