FIX Add logging for permission role codes

Author: robbieaverill

code/AuditHook.php

@@ -12,6 +12,7 @@
 use SilverStripe\Security\Group;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\PermissionRole;
+use SilverStripe\Security\PermissionRoleCode;
 use SilverStripe\Security\Security;
 
 /**
@@ -95,6 +96,7 @@ public static function handle_manipulation($manipulation)
             $schema->tableName(Member::class),
             $schema->tableName(Group::class),
             $schema->tableName(PermissionRole::class),
+            $schema->tableName(PermissionRoleCode::class),
         ];
 
         foreach ($manipulation as $table => $details) {
@@ -128,6 +130,12 @@ public static function handle_manipulation($manipulation)
                         implode($data->Codes()->column('Code'), ', ')
                     );
                 }
+                if ($table === $schema->tableName(PermissionRoleCode::class)) {
+                    $extendedText = sprintf(
+                        'Effective code: %s',
+                        $data->Code
+                    );
+                }
                 if ($table === $schema->tableName(Member::class)) {
                     $extendedText = sprintf(
                         'Effective groups: %s',

tests/AuditHookTest.php

@@ -3,17 +3,21 @@
 namespace SilverStripe\Auditor\Tests;
 
 use Page;
-use Silverstripe\Auditor\AuditHook;
 use SilverStripe\Auditor\Tests\AuditHookTest\Logger;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Dev\FunctionalTest;
 use SilverStripe\Security\Group;
 use SilverStripe\Security\Member;
+use SilverStripe\Security\PermissionRole;
+use SilverStripe\Security\PermissionRoleCode;
 
 class AuditHookTest extends FunctionalTest
 {
     protected $usesDatabase = true;
 
+    /**
+     * @var Logger
+     */
     protected $writer = null;
 
     protected function setUp()
@@ -159,6 +163,22 @@ public function testRemoveMemberFromGroupUsingMemberGroupsRelation()
         $this->assertContains('from Group "My group"', $message);
     }
 
+    public function testAddRoleCodeToRole()
+    {
+        $this->logInWithPermission('ADMIN');
+
+        $roleCode = new PermissionRoleCode(['Code' => 'grand_ruler']);
+        $roleCode->write();
+
+        $permissionRole = new PermissionRole(['Title' => 'Grand Ruler']);
+        $permissionRole->Codes()->add($roleCode);
+        $permissionRole->write();
+
+        $message = $this->writer->getLastMessage();
+        $this->assertContains('Effective code', $message);
+        $this->assertContains('grand_ruler', $message);
+    }
+
     public function testAddViewerGroupToPage()
     {
         if (!class_exists(Page::class)) {