We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our Error board in Honeycomb: https://ui.honeycomb.io/sil-thecombine/environments/prod/board/mEfYVUn7J2x
304 query in Honeycomb: https://ui.honeycomb.io/sil-thecombine/environments/prod/datasets/prod/result/EgcMQg9NFYp?vs=hideCompare&tab=traces
The text was updated successfully, but these errors were encountered:
We are intentionally using a 304 response but the error logged in Honeycomb is
System.InvalidOperationException: Writing to the response body is invalid for responses with status code 304.
I guess we're abusing 304 if we are using it with a response body:
return StatusCode(StatusCodes.Status304NotModified, editGuid);.
return StatusCode(StatusCodes.Status304NotModified, editGuid);
Perhaps we shouldn't use 304 for a "successful" response, even if the success is that no changes were name so nothing had to be done.
Sorry, something went wrong.
imnasnainaec
Successfully merging a pull request may close this issue.
Uh oh!
There was an error while loading. Please reload this page.
Our Error board in Honeycomb: https://ui.honeycomb.io/sil-thecombine/environments/prod/board/mEfYVUn7J2x
304 query in Honeycomb: https://ui.honeycomb.io/sil-thecombine/environments/prod/datasets/prod/result/EgcMQg9NFYp?vs=hideCompare&tab=traces
The text was updated successfully, but these errors were encountered: