Skip to content

Investigate 304 exceptions with POST v1/projects/{projectId}/useredits/{userEditId} #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imnasnainaec opened this issue May 14, 2025 · 1 comment · May be fixed by #3851 or #3815
Open

Investigate 304 exceptions with POST v1/projects/{projectId}/useredits/{userEditId} #3798

imnasnainaec opened this issue May 14, 2025 · 1 comment · May be fixed by #3851 or #3815
Assignees
Labels
backend bug Something isn't working question Further information is requested

Comments

@imnasnainaec
Copy link
Collaborator

imnasnainaec commented May 14, 2025

Our Error board in Honeycomb: https://ui.honeycomb.io/sil-thecombine/environments/prod/board/mEfYVUn7J2x

304 query in Honeycomb: https://ui.honeycomb.io/sil-thecombine/environments/prod/datasets/prod/result/EgcMQg9NFYp?vs=hideCompare&tab=traces

@imnasnainaec imnasnainaec added bug Something isn't working question Further information is requested backend labels May 14, 2025
@imnasnainaec
Copy link
Collaborator Author

We are intentionally using a 304 response but the error logged in Honeycomb is

System.InvalidOperationException: Writing to the response body is invalid for responses with status code 304.

I guess we're abusing 304 if we are using it with a response body:

return StatusCode(StatusCodes.Status304NotModified, editGuid);.

Perhaps we shouldn't use 304 for a "successful" response, even if the success is that no changes were name so nothing had to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working question Further information is requested
Projects
None yet
1 participant