Skip to content

Commit 678602d

Browse files
committed
Fix in-Stack map with keyed Fragments
1 parent c820ba2 commit 678602d

File tree

1 file changed

+18
-22
lines changed

1 file changed

+18
-22
lines changed

src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSensesCardContent.tsx

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
} from "@mui/icons-material";
99
import { CardContent, Divider, Grid2, Icon, Stack } from "@mui/material";
1010
import { grey, yellow } from "@mui/material/colors";
11-
import { type ReactElement, useEffect, useState } from "react";
11+
import { Fragment, type ReactElement, useEffect, useState } from "react";
1212

1313
import { type Sense, Status } from "api/models";
1414
import { IconButtonWithTooltip } from "components/Buttons";
@@ -52,31 +52,27 @@ export default function EditSensesCardContent(
5252
);
5353
}, [props.newSenses, props.oldSenses]);
5454

55-
const sensesAndDividers: ReactElement[] = [];
56-
props.newSenses.forEach((s, i) => {
57-
sensesAndDividers.push(
58-
<EditSense
59-
bumpSenseDown={
60-
i < props.newSenses.length - 1
61-
? () => props.moveSense(i, i + 1)
62-
: undefined
63-
}
64-
bumpSenseUp={i ? () => props.moveSense(i, i - 1) : undefined}
65-
edited={changes[i]}
66-
key={s.guid}
67-
sense={s}
68-
toggleSenseDeleted={() => props.toggleSenseDeleted(i)}
69-
updateSense={props.updateOrAddSense}
70-
/>
71-
);
72-
sensesAndDividers.push(<Divider key={i} />);
73-
});
74-
7555
return (
7656
<CardContent>
7757
{props.showSenses ? (
7858
<Stack spacing={1}>
79-
{sensesAndDividers}
59+
{props.newSenses.map((s, i) => (
60+
<Fragment key={s.guid}>
61+
<EditSense
62+
bumpSenseDown={
63+
i < props.newSenses.length - 1
64+
? () => props.moveSense(i, i + 1)
65+
: undefined
66+
}
67+
bumpSenseUp={i ? () => props.moveSense(i, i - 1) : undefined}
68+
edited={changes[i]}
69+
sense={s}
70+
toggleSenseDeleted={() => props.toggleSenseDeleted(i)}
71+
updateSense={props.updateOrAddSense}
72+
/>
73+
<Divider />
74+
</Fragment>
75+
))}
8076

8177
<IconButtonWithTooltip
8278
buttonId={EditSensesId.ButtonSenseAdd}

0 commit comments

Comments
 (0)