Skip to content

Commit 847c801

Browse files
authored
Fix peer down-scoring behaviour when gossip blobs/columns are received after getBlobs or reconstruction (#6686)
* Fix peer disconnection when gossip blobs/columns are received after they are recieved from the EL or available via column reconstruction.
1 parent 1c5be34 commit 847c801

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

beacon_node/network/src/network_beacon_processor/gossip_methods.rs

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,8 +710,19 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
710710
MessageAcceptance::Reject,
711711
);
712712
}
713+
GossipDataColumnError::PriorKnown { .. } => {
714+
// Data column is available via either the EL or reconstruction.
715+
// Do not penalise the peer.
716+
// Gossip filter should filter any duplicates received after this.
717+
debug!(
718+
self.log,
719+
"Received already available column sidecar. Ignoring the column sidecar";
720+
"slot" => %slot,
721+
"block_root" => %block_root,
722+
"index" => %index,
723+
)
724+
}
713725
GossipDataColumnError::FutureSlot { .. }
714-
| GossipDataColumnError::PriorKnown { .. }
715726
| GossipDataColumnError::PastFinalizedSlot { .. } => {
716727
debug!(
717728
self.log,
@@ -852,7 +863,18 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
852863
MessageAcceptance::Reject,
853864
);
854865
}
855-
GossipBlobError::FutureSlot { .. } | GossipBlobError::RepeatBlob { .. } => {
866+
GossipBlobError::RepeatBlob { .. } => {
867+
// We may have received the blob from the EL. Do not penalise the peer.
868+
// Gossip filter should filter any duplicates received after this.
869+
debug!(
870+
self.log,
871+
"Received already available blob sidecar. Ignoring the blob sidecar";
872+
"slot" => %slot,
873+
"root" => %root,
874+
"index" => %index,
875+
)
876+
}
877+
GossipBlobError::FutureSlot { .. } => {
856878
debug!(
857879
self.log,
858880
"Could not verify blob sidecar for gossip. Ignoring the blob sidecar";

0 commit comments

Comments
 (0)