Skip to content

Commit 4e25302

Browse files
committed
Address review comments and fix lint.
1 parent 0c9d64b commit 4e25302

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

beacon_node/beacon_chain/src/test_utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2085,7 +2085,7 @@ where
20852085
})
20862086
.transpose()
20872087
.expect("should convert blobs to columns")
2088-
.unwrap_or(vec![]);
2088+
.unwrap_or_default();
20892089
RpcBlock::new_with_custody_columns(Some(block_root), block, columns, &self.spec)?
20902090
} else {
20912091
let blobs = blob_items

beacon_node/network/src/service.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -789,6 +789,11 @@ impl<T: BeaconChainTypes> NetworkService<T> {
789789
/// 1. Data column subscription logic depends on subscription configuration.
790790
/// 2. Data column topic subscriptions will be dynamic based on validator balances due to
791791
/// validator custody.
792+
///
793+
/// TODO(das): The downside with not including it in core fork topic is - we subscribe to
794+
/// PeerDAS topics on startup if Fulu is scheduled, rather than waiting until the fork.
795+
/// If this is an issue we could potentially consider adding the logic to
796+
/// `network.subscribe_new_fork_topics()`.
792797
fn subscribe_to_peer_das_topics(&mut self, subscribed_topics: &mut Vec<GossipTopic>) {
793798
let column_subnets_to_subscribe = if self.subscribe_all_data_column_subnets {
794799
Cow::Owned(

0 commit comments

Comments
 (0)