PR comments

Author: pahor167

beacon_node/execution_layer/src/lib.rs

@@ -84,10 +84,6 @@ const EXECUTION_BLOCKS_LRU_CACHE_SIZE: NonZeroUsize = new_non_zero_usize(128);
 const DEFAULT_SUGGESTED_FEE_RECIPIENT: [u8; 20] =
     [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1];
 
-/// If default boost factor is provided in validator/blocks v3 request, we will skip the calculation
-/// to keep the precision.
-const DEFAULT_BOOST_FACTOR: u64 = 100;
-
 /// A payload alongside some information about where it came from.
 pub enum ProvenancedPayload<P> {
     /// A good old fashioned farm-to-table payload from your local EE.
@@ -1115,10 +1111,10 @@ impl<T: EthSpec> ExecutionLayer<T> {
                 let relay_value = *relay.data.message.value();
 
                 let boosted_relay_value = match builder_boost_factor {
-                    Some(builder_boost_factor) if (builder_boost_factor != DEFAULT_BOOST_FACTOR) => {
+                    Some(builder_boost_factor) => {
                         (relay_value / 100).saturating_mul(builder_boost_factor.into())
                     }
-                    _ => relay_value,
+                    None => relay_value,
                 };
 
                 let local_value = *local.block_value();

beacon_node/http_api/src/produce_block.rs

@@ -20,6 +20,10 @@ use warp::{
     Reply,
 };
 
+/// If default boost factor is provided in validator/blocks v3 request, we will skip the calculation
+/// to keep the precision.
+const DEFAULT_BOOST_FACTOR: u64 = 100;
+
 pub fn get_randao_verification(
     query: &api_types::ValidatorBlocksQuery,
     randao_reveal_infinity: bool,
@@ -52,14 +56,19 @@ pub async fn produce_block_v3<T: BeaconChainTypes>(
     })?;
 
     let randao_verification = get_randao_verification(&query, randao_reveal.is_infinity())?;
+    let builder_boost_factor = if query.builder_boost_factor == Some(DEFAULT_BOOST_FACTOR) {
+        None
+    } else {
+        query.builder_boost_factor
+    };
 
     let block_response_type = chain
         .produce_block_with_verification(
             randao_reveal,
             slot,
             query.graffiti,
             randao_verification,
-            query.builder_boost_factor,
+            builder_boost_factor,
             BlockProductionVersion::V3,
         )
         .await