Skip to content

feat(core/content-header): implement changes on content header #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

RamVinayMandal
Copy link
Contributor

@RamVinayMandal RamVinayMandal commented Jul 7, 2025

💡 What is the current behavior?

The content-header component lacks support for a header slot, limiting customization options for the header section.

JIRA ticket: IX-2486

🆕 What is the new behavior?

Feature:

  • ix-content-header now supports a header slot.
  • Content in <ix-pill slot="header"> (or similar) appears after the title and before action buttons.
  • Supports pills, chips, badges, or custom elements (per Figma/UX).
  • Spacing and alignment:
    • 8px total gap between title and slotted content (4px from title, 4px from pill).
    • 8px minimum gap to action buttons.
    • 6px top padding for slot content.
    • Handles overflow and wrapping for long titles or slot content.
  • Available and demonstrated in all frameworks (HTML, Angular, React, Vue).

Note: I'll raise the PR for ix-docs repo once it is merged.

Other:

  • Removed duplicate component declarations from app.module.ts in the Angular test app.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jul 7, 2025

⚠️ No Changeset found

Latest commit: 27c374d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RamVinayMandal RamVinayMandal marked this pull request as ready for review July 20, 2025 13:43
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant