chore: add more debugging logs for META and volumes

Doesn't fix anything, but the hope is that it would help
with #9852 and #9786.

Signed-off-by: Andrey Smirnov <[email protected]>
(cherry picked from commit b15917e)

Author: smira

Diff for: internal/app/machined/pkg/controllers/block/volume_manager.go

@@ -346,7 +346,28 @@ func (ctrl *VolumeManagerController) Run(ctx context.Context, r controller.Runti
 			}
 
 			if prevPhase != volumeStatus.Phase || err != nil {
-				volumeLogger.Info("volume status", zap.String("phase", fmt.Sprintf("%s -> %s", prevPhase, volumeStatus.Phase)), zap.Error(err))
+				fields := []zap.Field{
+					zap.String("phase", fmt.Sprintf("%s -> %s", prevPhase, volumeStatus.Phase)),
+					zap.Error(err),
+				}
+
+				if volumeStatus.Location != "" {
+					fields = append(fields, zap.String("location", volumeStatus.Location))
+				}
+
+				if volumeStatus.MountLocation != "" && volumeStatus.MountLocation != volumeStatus.Location {
+					fields = append(fields, zap.String("mountLocation", volumeStatus.MountLocation))
+				}
+
+				if volumeStatus.ParentLocation != "" {
+					fields = append(fields, zap.String("parentLocation", volumeStatus.ParentLocation))
+				}
+
+				if len(volumeStatus.EncryptionFailedSyncs) > 0 {
+					fields = append(fields, zap.Strings("encryptionFailedSyncs", volumeStatus.EncryptionFailedSyncs))
+				}
+
+				volumeLogger.Info("volume status", fields...)
 			}
 
 			allClosed = allClosed && volumeStatus.Phase == block.VolumePhaseClosed

Diff for: internal/pkg/meta/internal/adv/syslinux/syslinux.go

@@ -7,6 +7,7 @@ package syslinux
 
 import (
 	"encoding/binary"
+	"fmt"
 	"io"
 
 	"github.com/siderolabs/talos/internal/pkg/meta/internal/adv"
@@ -38,12 +39,12 @@ func NewADV(r io.ReadSeeker) (adv ADV, err error) {
 
 	_, err = r.Seek(-2*AdvSize, io.SeekEnd)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to seek for syslinux adv: %w", err)
 	}
 
 	_, err = io.ReadFull(r, b)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to read syslinux adv: %w", err)
 	}
 
 	adv = b

Diff for: internal/pkg/meta/internal/adv/talos/talos.go

@@ -71,7 +71,7 @@ func NewADV(r io.Reader) (*ADV, error) {
 
 	_, err := io.ReadFull(r, buf)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to load first block: %w", err)
 	}
 
 	if err = a.Unmarshal(buf); err == nil {
@@ -81,10 +81,14 @@ func NewADV(r io.Reader) (*ADV, error) {
 	// try 2nd copy
 	_, err = io.ReadFull(r, buf)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to load second block: %w", err)
+	}
+
+	if err = a.Unmarshal(buf); err != nil {
+		return a, fmt.Errorf("failed to unmarshal second block: %w", err)
 	}
 
-	return a, a.Unmarshal(buf)
+	return a, nil
 }
 
 // Unmarshal single copy from the serialized representation.

Diff for: internal/pkg/meta/meta.go

@@ -146,6 +146,8 @@ func (meta *Meta) Reload(ctx context.Context) error {
 		defer parentDev.Unlock() //nolint:errcheck
 	}
 
+	meta.opts.printer("META: loading from %s", path)
+
 	f, err := os.Open(path)
 	if err != nil {
 		return err
@@ -160,12 +162,12 @@ func (meta *Meta) Reload(ctx context.Context) error {
 	adv, err := talos.NewADV(f)
 	if adv == nil && err != nil {
 		// if adv is not nil, but err is nil, it might be missing ADV, ignore it
-		return err
+		return fmt.Errorf("failed to load Talos adv: %w", err)
 	}
 
 	legacyAdv, err := syslinux.NewADV(f)
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to load syslinux adv: %w", err)
 	}
 
 	// copy values from in-memory to on-disk version
@@ -244,6 +246,8 @@ func (meta *Meta) Flush() error {
 		defer parentDev.Unlock() //nolint:errcheck
 	}
 
+	meta.opts.printer("META: saving to %s", path)
+
 	f, err := os.OpenFile(path, os.O_RDWR, 0)
 	if err != nil {
 		return err