forked from rescript-lang/rescript
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathres_parens.ml
467 lines (441 loc) · 15.9 KB
/
res_parens.ml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
module ParsetreeViewer = Res_parsetree_viewer
type kind = Parenthesized | Braced of Location.t | Nothing
let expr expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| _ -> (
match expr with
| {
Parsetree.pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_constraint _} -> Parenthesized
| _ -> Nothing)
let expr_record_row_rhs e =
let kind = expr e in
match kind with
| Nothing when Res_parsetree_viewer.has_optional_attribute e.pexp_attributes
-> (
match e.pexp_desc with
| Pexp_ifthenelse _ | Pexp_fun _ -> Parenthesized
| _ -> kind)
| _ -> kind
let call_expr expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| _ -> (
match expr with
| {Parsetree.pexp_attributes = attrs}
when match ParsetreeViewer.filter_parsing_attrs attrs with
| _ :: _ -> true
| [] -> false ->
Parenthesized
| _
when ParsetreeViewer.is_unary_expression expr
|| ParsetreeViewer.is_binary_expression expr ->
Parenthesized
| {
Parsetree.pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_fun _}
when ParsetreeViewer.is_underscore_apply_sugar expr ->
Nothing
| {
pexp_desc =
( Pexp_lazy _ | Pexp_assert _ | Pexp_fun _ | Pexp_newtype _
| Pexp_function _ | Pexp_constraint _ | Pexp_setfield _ | Pexp_match _
| Pexp_try _ | Pexp_while _ | Pexp_for _ | Pexp_ifthenelse _ );
} ->
Parenthesized
| _ when Ast_uncurried.expr_is_uncurried_fun expr -> Parenthesized
| _ when ParsetreeViewer.has_await_attribute expr.pexp_attributes ->
Parenthesized
| _ -> Nothing)
let structure_expr expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| _
when ParsetreeViewer.has_attributes expr.pexp_attributes
&& not (ParsetreeViewer.is_jsx_expression expr) ->
Parenthesized
| {
Parsetree.pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_constraint _} -> Parenthesized
| _ -> Nothing)
let unary_expr_operand expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {Parsetree.pexp_attributes = attrs}
when match ParsetreeViewer.filter_parsing_attrs attrs with
| _ :: _ -> true
| [] -> false ->
Parenthesized
| expr
when ParsetreeViewer.is_unary_expression expr
|| ParsetreeViewer.is_binary_expression expr ->
Parenthesized
| {
pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_fun _}
when ParsetreeViewer.is_underscore_apply_sugar expr ->
Nothing
| {
pexp_desc =
( Pexp_lazy _ | Pexp_assert _ | Pexp_fun _ | Pexp_newtype _
| Pexp_function _ | Pexp_constraint _ | Pexp_setfield _
| Pexp_extension _ (* readability? maybe remove *) | Pexp_match _
| Pexp_try _ | Pexp_while _ | Pexp_for _ | Pexp_ifthenelse _ );
} ->
Parenthesized
| _ when ParsetreeViewer.has_await_attribute expr.pexp_attributes ->
Parenthesized
| {pexp_desc = Pexp_construct ({txt = Lident "Function$"}, Some expr)}
when ParsetreeViewer.is_underscore_apply_sugar expr ->
Nothing
| {pexp_desc = Pexp_construct ({txt = Lident "Function$"}, Some _)} ->
Parenthesized
| _ -> Nothing)
let binary_expr_operand ~is_lhs expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {
Parsetree.pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_fun _}
when ParsetreeViewer.is_underscore_apply_sugar expr ->
Nothing
| {
pexp_desc =
Pexp_constraint _ | Pexp_fun _ | Pexp_function _ | Pexp_newtype _;
} ->
Parenthesized
| _ when Ast_uncurried.expr_is_uncurried_fun expr -> Parenthesized
| expr when ParsetreeViewer.is_binary_expression expr -> Parenthesized
| expr when ParsetreeViewer.is_ternary_expr expr -> Parenthesized
| {pexp_desc = Pexp_lazy _ | Pexp_assert _} when is_lhs -> Parenthesized
| _ when ParsetreeViewer.has_await_attribute expr.pexp_attributes ->
Parenthesized
| {Parsetree.pexp_attributes = attrs} ->
if ParsetreeViewer.has_printable_attributes attrs then Parenthesized
else Nothing)
let sub_binary_expr_operand parent_operator child_operator =
let prec_parent = ParsetreeViewer.operator_precedence parent_operator in
let prec_child = ParsetreeViewer.operator_precedence child_operator in
prec_parent > prec_child
|| prec_parent == prec_child
&& not
(ParsetreeViewer.flattenable_operators parent_operator child_operator)
|| (* a && b || c, add parens to (a && b) for readability, who knows the difference by heart… *)
(parent_operator = "||" && child_operator = "&&")
let rhs_binary_expr_operand parent_operator rhs =
match rhs.Parsetree.pexp_desc with
| Parsetree.Pexp_apply
( {
pexp_attributes = [];
pexp_desc =
Pexp_ident {txt = Longident.Lident operator; loc = operator_loc};
},
[(_, _left); (_, _right)] )
when ParsetreeViewer.is_binary_operator operator
&& not (operator_loc.loc_ghost && operator = "^") ->
let prec_parent = ParsetreeViewer.operator_precedence parent_operator in
let prec_child = ParsetreeViewer.operator_precedence operator in
prec_parent == prec_child
| _ -> false
let flatten_operand_rhs parent_operator rhs =
match rhs.Parsetree.pexp_desc with
| Parsetree.Pexp_apply
( {
pexp_desc =
Pexp_ident {txt = Longident.Lident operator; loc = operator_loc};
},
[(_, _left); (_, _right)] )
when ParsetreeViewer.is_binary_operator operator
&& not (operator_loc.loc_ghost && operator = "^") ->
let prec_parent = ParsetreeViewer.operator_precedence parent_operator in
let prec_child = ParsetreeViewer.operator_precedence operator in
prec_parent >= prec_child || rhs.pexp_attributes <> []
| Pexp_construct ({txt = Lident "Function$"}, Some _) -> true
| Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _}) ->
false
| Pexp_fun _ when ParsetreeViewer.is_underscore_apply_sugar rhs -> false
| Pexp_fun _ | Pexp_newtype _ | Pexp_setfield _ | Pexp_constraint _ -> true
| _ when ParsetreeViewer.is_ternary_expr rhs -> true
| _ -> false
let binary_operator_inside_await_needs_parens operator =
ParsetreeViewer.operator_precedence operator
< ParsetreeViewer.operator_precedence "|."
let lazy_or_assert_or_await_expr_rhs ?(in_await = false) expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {Parsetree.pexp_attributes = attrs}
when match ParsetreeViewer.filter_parsing_attrs attrs with
| _ :: _ -> true
| [] -> false ->
Parenthesized
| {
pexp_desc =
Pexp_apply ({pexp_desc = Pexp_ident {txt = Longident.Lident operator}}, _);
}
when ParsetreeViewer.is_binary_expression expr ->
if in_await && not (binary_operator_inside_await_needs_parens operator)
then Nothing
else Parenthesized
| {
pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_fun _}
when ParsetreeViewer.is_underscore_apply_sugar expr ->
Nothing
| {
pexp_desc =
( Pexp_lazy _ | Pexp_assert _ | Pexp_fun _ | Pexp_newtype _
| Pexp_function _ | Pexp_constraint _ | Pexp_setfield _ | Pexp_match _
| Pexp_try _ | Pexp_while _ | Pexp_for _ | Pexp_ifthenelse _ );
} ->
Parenthesized
| _
when (not in_await)
&& ParsetreeViewer.has_await_attribute expr.pexp_attributes ->
Parenthesized
| _ -> Nothing)
let is_negative_constant constant =
let is_neg txt =
let len = String.length txt in
len > 0 && (String.get [@doesNotRaise]) txt 0 = '-'
in
match constant with
| (Parsetree.Pconst_integer (i, _) | Pconst_float (i, _)) when is_neg i ->
true
| _ -> false
let field_expr expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {Parsetree.pexp_attributes = attrs}
when match ParsetreeViewer.filter_parsing_attrs attrs with
| _ :: _ -> true
| [] -> false ->
Parenthesized
| expr
when ParsetreeViewer.is_binary_expression expr
|| ParsetreeViewer.is_unary_expression expr ->
Parenthesized
| {
pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_constant c} when is_negative_constant c -> Parenthesized
| {pexp_desc = Pexp_fun _}
when ParsetreeViewer.is_underscore_apply_sugar expr ->
Nothing
| {
pexp_desc =
( Pexp_lazy _ | Pexp_assert _
| Pexp_extension _ (* %extension.x vs (%extension).x *) | Pexp_fun _
| Pexp_newtype _ | Pexp_function _ | Pexp_constraint _ | Pexp_setfield _
| Pexp_match _ | Pexp_try _ | Pexp_while _ | Pexp_for _
| Pexp_ifthenelse _ );
} ->
Parenthesized
| _ when ParsetreeViewer.has_await_attribute expr.pexp_attributes ->
Parenthesized
| {pexp_desc = Pexp_construct ({txt = Lident "Function$"}, Some expr)}
when ParsetreeViewer.is_underscore_apply_sugar expr ->
Nothing
| {pexp_desc = Pexp_construct ({txt = Lident "Function$"}, Some _)} ->
Parenthesized
| _ -> Nothing)
let set_field_expr_rhs expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {
Parsetree.pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_constraint _} -> Parenthesized
| _ -> Nothing)
let ternary_operand expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {
Parsetree.pexp_desc =
Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
} ->
Nothing
| {pexp_desc = Pexp_constraint _} -> Parenthesized
| _ when Res_parsetree_viewer.is_fun_newtype expr -> (
let _uncurried, _attrsOnArrow, _parameters, return_expr =
ParsetreeViewer.fun_expr expr
in
match return_expr.pexp_desc with
| Pexp_constraint _ -> Parenthesized
| _ -> Nothing)
| _ -> Nothing)
let starts_with_minus txt =
let len = String.length txt in
if len == 0 then false
else
let s = (String.get [@doesNotRaise]) txt 0 in
s = '-'
let jsx_prop_expr expr =
match expr.Parsetree.pexp_desc with
| Parsetree.Pexp_let _ | Pexp_sequence _ | Pexp_letexception _
| Pexp_letmodule _ | Pexp_open _ ->
Nothing
| _ -> (
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {
Parsetree.pexp_desc =
Pexp_constant (Pconst_integer (x, _) | Pconst_float (x, _));
pexp_attributes = [];
}
when starts_with_minus x ->
Parenthesized
| _ when ParsetreeViewer.has_await_attribute expr.pexp_attributes ->
Parenthesized
| {
Parsetree.pexp_desc =
( Pexp_ident _ | Pexp_constant _ | Pexp_field _ | Pexp_construct _
| Pexp_variant _ | Pexp_array _ | Pexp_pack _ | Pexp_record _
| Pexp_extension _ | Pexp_letmodule _ | Pexp_letexception _
| Pexp_open _ | Pexp_sequence _ | Pexp_let _ | Pexp_tuple _ );
pexp_attributes = [];
} ->
Nothing
| {
Parsetree.pexp_desc =
Pexp_constraint
({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
pexp_attributes = [];
} ->
Nothing
| _ -> Parenthesized))
let jsx_child_expr expr =
match expr.Parsetree.pexp_desc with
| Parsetree.Pexp_let _ | Pexp_sequence _ | Pexp_letexception _
| Pexp_letmodule _ | Pexp_open _ ->
Nothing
| _ -> (
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| _ -> (
match expr with
| {
Parsetree.pexp_desc =
Pexp_constant (Pconst_integer (x, _) | Pconst_float (x, _));
pexp_attributes = [];
}
when starts_with_minus x ->
Parenthesized
| _ when ParsetreeViewer.has_await_attribute expr.pexp_attributes ->
Parenthesized
| {
Parsetree.pexp_desc =
( Pexp_ident _ | Pexp_constant _ | Pexp_field _ | Pexp_construct _
| Pexp_variant _ | Pexp_array _ | Pexp_pack _ | Pexp_record _
| Pexp_extension _ | Pexp_letmodule _ | Pexp_letexception _
| Pexp_open _ | Pexp_sequence _ | Pexp_let _ );
pexp_attributes = [];
} ->
Nothing
| {
Parsetree.pexp_desc =
Pexp_constraint
({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _});
pexp_attributes = [];
} ->
Nothing
| expr when ParsetreeViewer.is_jsx_expression expr -> Nothing
| _ -> Parenthesized))
let binary_expr expr =
let opt_braces, _ = ParsetreeViewer.process_braces_attr expr in
match opt_braces with
| Some ({Location.loc = braces_loc}, _) -> Braced braces_loc
| None -> (
match expr with
| {Parsetree.pexp_attributes = _ :: _} as expr
when ParsetreeViewer.is_binary_expression expr ->
Parenthesized
| _ -> Nothing)
let mod_type_functor_return mod_type =
match mod_type with
| {Parsetree.pmty_desc = Pmty_with _} -> true
| _ -> false
(* Add parens for readability:
module type Functor = SetLike => Set with type t = A.t
This is actually:
module type Functor = (SetLike => Set) with type t = A.t
*)
let mod_type_with_operand mod_type =
match mod_type with
| {Parsetree.pmty_desc = Pmty_functor _ | Pmty_with _} -> true
| _ -> false
let mod_expr_functor_constraint mod_type =
match mod_type with
| {Parsetree.pmty_desc = Pmty_functor _ | Pmty_with _} -> true
| _ -> false
let braced_expr expr =
match expr.Parsetree.pexp_desc with
| Pexp_constraint ({pexp_desc = Pexp_pack _}, {ptyp_desc = Ptyp_package _}) ->
false
| Pexp_constraint _ -> true
| _ -> false
let include_mod_expr mod_expr =
match mod_expr.Parsetree.pmod_desc with
| Parsetree.Pmod_constraint _ -> true
| _ -> false
let arrow_return_typ_expr typ_expr =
match typ_expr.Parsetree.ptyp_desc with
| Parsetree.Ptyp_arrow _ -> true
| _ when Ast_uncurried.core_type_is_uncurried_fun typ_expr -> true
| _ -> false
let pattern_record_row_rhs (pattern : Parsetree.pattern) =
match pattern.ppat_desc with
| Ppat_constraint ({ppat_desc = Ppat_unpack _}, {ptyp_desc = Ptyp_package _})
->
false
| Ppat_constraint _ -> true
| _ -> false