Applying SwiftLint with Mint

shtnkgm · shtnkgm · commit 87d672b9fd15 · 2021-09-22T23:53:51.000+09:00
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -1,85 +1,170 @@
 disabled_rules:
-- identifier_name
-- implicit_return
-- multiple_closures_with_trailing_closure
-- empty_enum_arguments
-- explicit_top_level_acl
-- conditional_returns_on_newline
-- closure_end_indentation
-- discouraged_optional_collection
-- explicit_enum_raw_value
-- explicit_type_interface
-- fatal_error_message
-- file_header
-- lower_acl_than_parent
-- no_extension_access_modifier
-- no_grouping_extension
-- multiline_arguments
-- strict_fileprivate
-- switch_case_on_newline
-- trailing_closure
-- large_tuple
-- explicit_acl
-- attributes
-- let_var_whitespace
+  - attributes
+  - array_init
+  - closure_body_length
+  - conditional_returns_on_newline
+  - cyclomatic_complexity
+  - discouraged_optional_boolean
+  - discouraged_optional_collection
+  - explicit_acl
+  - explicit_enum_raw_value
+  - explicit_top_level_acl
+  - explicit_type_interface
+  - extension_access_modifier
+  - fatal_error_message
+  - file_header
+  - file_types_order
+  - file_length
+  - function_body_length
+  - function_default_parameter_at_end
+  - function_parameter_count
+  - indentation_width
+  - implicit_return
+  - lower_acl_than_parent
+  - no_extension_access_modifier
+  - no_grouping_extension
+  - number_separator
+  - missing_docs
+  - modifier_order
+  - multiline_arguments
+  - multiple_closures_with_trailing_closure
+  - multiline_arguments_brackets
+  - multiline_parameters_brackets
+  - object_literal
+  - operator_usage_whitespace
+  - pattern_matching_keywords
+  - private_action
+  - private_outlet
+  - prefixed_toplevel_constant
+  - prohibited_interface_builder
+  - raw_value_for_camel_cased_codable_enum
+  - required_deinit
+  - sorted_imports
+  - strict_fileprivate
+  - strong_iboutlet
+  - switch_case_on_newline
+  - trailing_whitespace
+  - trailing_closure
+  - type_contents_order
+  - todo
+  - unavailable_function
+  - unneeded_parentheses_in_closure_argument
+  - unused_setter_value
+  - xctfail_message
+  - xct_specific_matcher
+  - line_length
+  - force_unwrapping
+  - let_var_whitespace
+  - file_name
 
 opt_in_rules:
-- array_init
-- attributes
-- closure_end_indentation
-- closure_spacing
-- conditional_returns_on_newline
-- contains_over_first_not_nil
-- discouraged_object_literal
-- discouraged_optional_boolean
-- discouraged_optional_collection
-- empty_count
-- empty_string
-- explicit_acl
-- explicit_enum_raw_value
-- explicit_init
-- explicit_top_level_acl
-- explicit_type_interface
-- extension_access_modifier
-- fatal_error_message
-- file_header
-- first_where
-- force_unwrapping
-- implicit_return
-- implicitly_unwrapped_optional
-- joined_default_parameter
-- let_var_whitespace
-- literal_expression_end_indentation
-- multiline_arguments
-- multiline_parameters
-- nimble_operator
-- no_extension_access_modifier
-- no_grouping_extension
-- number_separator
-- object_literal
-- operator_usage_whitespace
-- overridden_super_call
-- override_in_extension
-- pattern_matching_keywords
-- prefixed_toplevel_constant
-- private_action
-- private_outlet
-- prohibited_super_call
-- quick_discouraged_call
-- quick_discouraged_focused_test
-- quick_discouraged_pending_test
-- redundant_nil_coalescing
-- required_enum_case
-- single_test_class
-- sorted_first_last
-- sorted_imports
-- strict_fileprivate
-- switch_case_on_newline
-- trailing_closure
-- unneeded_parentheses_in_closure_argument
-- untyped_error_in_catch
-- vertical_parameter_alignment_on_call
-- yoda_condition
+  - anyobject_protocol
+  - array_init
+  - attributes
+  - closure_body_length
+  - closure_end_indentation
+  - closure_spacing
+  - collection_alignment
+  - conditional_returns_on_newline
+  - contains_over_filter_count
+  - contains_over_filter_is_empty
+  - contains_over_first_not_nil
+  - contains_over_range_nil_comparison
+  - convenience_type
+  - discouraged_object_literal
+  - discouraged_optional_boolean
+  - discouraged_optional_collection
+  - empty_collection_literal
+  - empty_count
+  - empty_string
+  - empty_xctest_method
+  - enum_case_associated_values_count
+  - expiring_todo
+  - explicit_acl
+  - explicit_enum_raw_value
+  - explicit_init
+  - explicit_self
+  - explicit_top_level_acl
+  - explicit_type_interface
+  - extension_access_modifier
+  - fallthrough
+  - fatal_error_message
+  - file_header
+  - file_name
+  - file_name_no_space
+  - file_types_order
+  - first_where
+  - flatmap_over_map_reduce
+  - force_unwrapping
+  - function_default_parameter_at_end
+  - identical_operands
+  - implicit_return
+  - implicitly_unwrapped_optional
+  - indentation_width
+  - joined_default_parameter
+  - last_where
+  - legacy_multiple
+  - legacy_random
+  - let_var_whitespace
+  - literal_expression_end_indentation
+  - lower_acl_than_parent
+  - missing_docs
+  - modifier_order
+  - multiline_arguments
+  - multiline_arguments_brackets
+  - multiline_function_chains
+  - multiline_literal_brackets
+  - multiline_parameters
+  - multiline_parameters_brackets
+  - nimble_operator
+  - no_extension_access_modifier
+  - no_grouping_extension
+  - nslocalizedstring_key
+  - nslocalizedstring_require_bundle
+  - number_separator
+  - object_literal
+  - operator_usage_whitespace
+  - optional_enum_case_matching
+  - overridden_super_call
+  - override_in_extension
+  - pattern_matching_keywords
+  - prefer_self_type_over_type_of_self
+  - prefixed_toplevel_constant
+  - private_action
+  - private_outlet
+  - prohibited_interface_builder
+  - prohibited_super_call
+  - quick_discouraged_call
+  - quick_discouraged_focused_test
+  - quick_discouraged_pending_test
+  - raw_value_for_camel_cased_codable_enum
+  - reduce_into
+  - redundant_nil_coalescing
+  - redundant_type_annotation
+  - required_deinit
+  - required_enum_case
+  - single_test_class
+  - sorted_first_last
+  - sorted_imports
+  - static_operator
+  - strict_fileprivate
+  - strong_iboutlet
+  - switch_case_on_newline
+  - toggle_bool
+  - trailing_closure
+  - type_contents_order
+  - unavailable_function
+  - unneeded_parentheses_in_closure_argument
+  - unowned_variable_capture
+  - untyped_error_in_catch
+  - unused_declaration
+  - unused_import
+  - vertical_parameter_alignment_on_call
+  - vertical_whitespace_between_cases
+  - vertical_whitespace_closing_braces
+  - vertical_whitespace_opening_braces
+  - xct_specific_matcher
+  - yoda_condition
 
 included:
   - ImageTransition
@@ -88,37 +173,6 @@ included:
 # Lint対象から除外するパス
 excluded:
 
-line_length:
-- 200   # warning
-- 300   # error
-
-type_body_length:
-- 400   # warning
-- 600   # error
-
-file_length:
-- 500   # warning
-- 1000  # error
-
-function_body_length:
-- 100   # warning
-- 200   # error
-
-type_name:
-min_length: 3
-max_length:
-warning: 40
-error: 50
-excluded:
-
-identifier_name:
-min_length: # only min_length
-error: 2 # only error
-excluded: # excluded via string array
-- id
-- URL
-reporter: "xcode"
-
 custom_rules:
   final_class:
     included: "./.*\\.swift"
diff --git a/ImageTransition.xcodeproj/project.pbxproj b/ImageTransition.xcodeproj/project.pbxproj
@@ -340,7 +340,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if which swiftlint >/dev/null; then\n  swiftlint\n  swiftlint autocorrect\nelse\n  echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
+			shellScript = "if [ \"${CONFIGURATION}\" = \"Debug\" ]; then\n  xcrun --sdk macosx mint run swiftlint autocorrect --format\n  xcrun --sdk macosx mint run swiftlint\nfi\n";
 		};
 /* End PBXShellScriptBuildPhase section */
 
diff --git a/ImageTransition/ImageTransitionDelegate.swift b/ImageTransition/ImageTransitionDelegate.swift
@@ -24,9 +24,11 @@ public final class ImageTransitionDelegate: NSObject {
 }
 
 extension ImageTransitionDelegate: UIViewControllerTransitioningDelegate {
-    public func animationController(forPresented presented: UIViewController,
-                                    presenting: UIViewController,
-                                    source: UIViewController) -> UIViewControllerAnimatedTransitioning? {
+    public func animationController(
+        forPresented presented: UIViewController,
+        presenting: UIViewController,
+        source: UIViewController
+    ) -> UIViewControllerAnimatedTransitioning? {
         ImageTransitioning(duration: presentDuration, animationOptions: presentAnimationOptions)
     }
 
@@ -36,17 +38,22 @@ extension ImageTransitionDelegate: UIViewControllerTransitioningDelegate {
 }
 
 extension ImageTransitionDelegate: UINavigationControllerDelegate {
-    public func navigationController(_ navigationController: UINavigationController,
-                                     animationControllerFor operation: UINavigationController.Operation,
-                                     from fromVC: UIViewController,
-                                     to toVC: UIViewController) -> UIViewControllerAnimatedTransitioning? {
+    public func navigationController(
+        _ navigationController: UINavigationController,
+        animationControllerFor operation: UINavigationController.Operation,
+        from fromVC: UIViewController,
+        to toVC: UIViewController
+    ) -> UIViewControllerAnimatedTransitioning? {
         switch operation {
         case .none:
             return nil
+
         case .pop:
             return ImageTransitioning(duration: popDuration, animationOptions: popAnimationOptions)
+
         case .push:
             return ImageTransitioning(duration: pushDuration, animationOptions: pushAnimationOptions)
+
         @unknown default:
             fatalError()
         }
diff --git a/ImageTransition/ImageTransitioning.swift b/ImageTransition/ImageTransitioning.swift
@@ -22,12 +22,30 @@ internal final class ImageTransitioning: NSObject, UIViewControllerAnimatedTrans
     }
 
     internal func animateTransition(using transitionContext: UIViewControllerContextTransitioning) {
-        guard let fromVC = transitionContext.viewController(forKey: .from) else { assertionFailure("fromVC is nil"); return }
-        guard let toVC = transitionContext.viewController(forKey: .to) else { assertionFailure("toVC is nil"); return }
-        guard let fromImageView = (fromVC as? ImageTransitionable)?.imageViewForTransition else { assertionFailure("fromImageView is nil"); return }
-        guard let toImageView = (toVC as? ImageTransitionable)?.imageViewForTransition else { assertionFailure("toImageView is nil"); return }
-        guard let fromImage = fromImageView.image else { assertionFailure("fromImage is nil"); return }
-        guard let toImage = toImageView.image else { assertionFailure("toImage is nil"); return }
+        guard let fromVC = transitionContext.viewController(forKey: .from) else {
+            assertionFailure("fromVC is nil")
+            return
+        }
+        guard let toVC = transitionContext.viewController(forKey: .to) else {
+            assertionFailure("toVC is nil")
+            return
+        }
+        guard let fromImageView = (fromVC as? ImageTransitionable)?.imageViewForTransition else {
+            assertionFailure("fromImageView is nil")
+            return
+        }
+        guard let toImageView = (toVC as? ImageTransitionable)?.imageViewForTransition else {
+            assertionFailure("toImageView is nil")
+            return
+        }
+        guard let fromImage = fromImageView.image else {
+            assertionFailure("fromImage is nil")
+            return
+        }
+        guard let toImage = toImageView.image else {
+            assertionFailure("toImage is nil")
+            return
+        }
 
         // Use image with larger size
         let movingView = UIImageView(image: fromImage.largerCompared(with: toImage))
diff --git a/ImageTransition/UIImageView+.swift b/ImageTransition/UIImageView+.swift
@@ -15,6 +15,7 @@ internal extension UIImageView {
         switch contentMode {
         case .scaleAspectFit:
             return AVMakeRect(aspectRatio: image.size, insideRect: bounds).size
+
         default:
             return bounds.size
         }
diff --git a/Mintfile b/Mintfile
@@ -0,0 +1 @@
+realm/SwiftLint@0.42.0

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ internal extension UIImageView {`
`15`	`15`	`switch contentMode {`
`16`	`16`	`case .scaleAspectFit:`
`17`	`17`	`return AVMakeRect(aspectRatio: image.size, insideRect: bounds).size`
	`18`	`+`
`18`	`19`	`default:`
`19`	`20`	`return bounds.size`
`20`	`21`	`}`