NEXT-37398 - Improve validation of feature flag name in FeatureCallSilentToken

shyim · pweyck · commit d35ee2eda5c9 · 2024-08-08T14:23:18.000+02:00
diff --git a/Framework/Adapter/Twig/Node/FeatureCallSilentToken.php b/Framework/Adapter/Twig/Node/FeatureCallSilentToken.php
@@ -22,7 +22,9 @@ public function compile(Compiler $compiler): void
     {
         $compiler
             ->addDebugInfo($this)
-            ->raw('\Shopware\Core\Framework\Feature::callSilentIfInactive(\'' . $this->flag . '\', function () use(&$context) { ')
+            ->raw('\Shopware\Core\Framework\Feature::callSilentIfInactive(')
+            ->string($this->flag)
+            ->raw(', function () use(&$context) { ')
             ->subcompile($this->getNode('body'))
             ->raw('});');
     }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,9 @@ public function compile(Compiler $compiler): void`
`22`	`22`	`{`
`23`	`23`	`$compiler`
`24`	`24`	`->addDebugInfo($this)`
`25`		`- ->raw('\Shopware\Core\Framework\Feature::callSilentIfInactive(\'' . $this->flag . '\', function () use(&$context) { ')`
	`25`	`+ ->raw('\Shopware\Core\Framework\Feature::callSilentIfInactive(')`
	`26`	`+ ->string($this->flag)`
	`27`	`+ ->raw(', function () use(&$context) { ')`
`26`	`28`	`->subcompile($this->getNode('body'))`
`27`	`29`	`->raw('});');`
`28`	`30`	`}`