Skip to content

Show WebClient version as soon as possible. #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
the-hotmann opened this issue Aug 13, 2020 · 3 comments · Fixed by #298
Closed

Show WebClient version as soon as possible. #293

the-hotmann opened this issue Aug 13, 2020 · 3 comments · Fixed by #298
Assignees
Labels
Milestone

Comments

@the-hotmann
Copy link
Contributor

ATM the version of Server and Client is shown just when you enter a Server.
Makes sense for the Server-Version. But the WebClient version can be shown as soon as possible and even before loging in a server.

Start:
Start (no version)
No Version info, but could show "Client vx.x.x"

Logged in Server:
Server (with version)
With needed versions 👍

@acelaya
Copy link
Member

acelaya commented Aug 14, 2020

Yep, it makes sense. I have considered it too.

@the-hotmann
Copy link
Contributor Author

the-hotmann commented Aug 14, 2020

Also another recommendation:

ATM it is like this:

Client: v2.5.1 - Server: v2.3.0

More clever would be:

Server: v2.3.0 - Client: v2.5.1 (other order, first Server, then Client as this is fixed on right side for desktop)

As then the div could be fixed and would not change if "Server version" are provided.So there would be not difference for the position of "Client version". Hope you understand what I mean.

And in the "Setting" also the version is not provided. Maybe this should be implemented everywhere.

@acelaya acelaya added this to the 2.6.0 milestone Aug 22, 2020
@acelaya acelaya self-assigned this Aug 28, 2020
@acelaya
Copy link
Member

acelaya commented Sep 6, 2020

All done!

Client version now is always displayed, regardless the section. In fact, it will show in future sections if added, as the element is now in a parent element.

The server version is then dynamically displayed only if you are connected to any of them.

This will be part of v2.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants