Merge pull request #1814 from mmorel-35/thelper+usetesting

chore: enable thelper and usetesting linters

Author: shirou

.golangci.yml

@@ -22,8 +22,10 @@ linters:
     - predeclared
     - revive
     - testifylint
+    - thelper
     - typecheck
     - unparam
+    - usetesting
   disable:
     - errcheck
     - govet
@@ -100,3 +102,23 @@ linters-settings:
         disabled: true
   testifylint:
     enable-all: true
+  thelper:
+    test:
+      # Check t.Helper() begins helper function.
+      # Default: true
+      begin: false
+    benchmark:
+      # Check b.Helper() begins helper function.
+      # Default: true
+      begin: false
+    tb:
+      # Check tb.Helper() begins helper function.
+      # Default: true
+      begin: false
+    fuzz:
+      # Check f.Helper() begins helper function.
+      # Default: true
+      begin: false
+  usetesting:
+      os-create-temp: false
+      os-mkdir-temp: false

load/load_test.go

@@ -9,9 +9,9 @@ import (
 	"github.com/shirou/gopsutil/v4/internal/common"
 )
 
-func skipIfNotImplementedErr(t testing.TB, err error) {
+func skipIfNotImplementedErr(tb testing.TB, err error) {
 	if errors.Is(err, common.ErrNotImplementedError) {
-		t.Skip("not implemented")
+		tb.Skip("not implemented")
 	}
 }
 
@@ -72,15 +72,15 @@ func TestMiscStatString(t *testing.T) {
 }
 
 func BenchmarkLoad(b *testing.B) {
-	loadAvg := func(t testing.TB) {
+	loadAvg := func(tb testing.TB) {
 		v, err := Avg()
-		skipIfNotImplementedErr(t, err)
+		skipIfNotImplementedErr(tb, err)
 		if err != nil {
-			t.Errorf("error %v", err)
+			tb.Errorf("error %v", err)
 		}
 		empty := &AvgStat{}
 		if v == empty {
-			t.Errorf("error load: %v", v)
+			tb.Errorf("error load: %v", v)
 		}
 	}